Issue metadata
Sign in to add a comment
|
amd64-generic-asan: chromeos-base/cryptohome unittest is failing |
||||||||||||||||||||||||
Issue descriptioncryptohome-0.0.1-r2592: Error: /var/cache/portage/chromeos-base/cryptohome/out/Default/cryptohome_testrunner: failed with exit code 1 It is not clear to me from the logs exactly which unittest is failing and if there's a failure message from that test. See build https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8942472816741899760 for details.
,
Jun 28 2018
Seems caused by https://chromium-review.googlesource.com/1112558. Assign to Jorge.
,
Jun 28 2018
Are you sure? That CL is modifying a completely different part of the code...
,
Jun 28 2018
Like, the stack traces touch none of the new code.
,
Jun 28 2018
Jorge: Sorry, somehow I coped a wrong CL link that had you as author. emaxx@ should be the right person to look at this. https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1105040
,
Jul 10
What's the current status of this? Is any progress being made?
,
Jul 10
Looking into this right now, seems like an error in defining a testing string constant. (Sorry for slow reply - thanks for pinging! Seems like the original notification was lost due to a recent problem with @chromium.org accounts e-mail linking.)
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/663e1902e8359a5fdf4de75d78e1fc155ae7872e commit 663e1902e8359a5fdf4de75d78e1fc155ae7872e Author: Maksim Ivanov <emaxx@google.com> Date: Thu Jul 12 01:48:53 2018 cryptohome: ASAN fix for test of signature-sealing backend This fixes failures of the ChallengeCredentialsDecryptOperationBasicTest unit tests under ASAN, as stack-buffer-overflow was happening when constructing an std::string from an array of char which was not null-terminated. BUG= chromium:857596 ,chromium:842791 TEST=existing unit tests Change-Id: I958c5cbd380ef5a10d57e0baabb06090355236dc Reviewed-on: https://chromium-review.googlesource.com/1131945 Commit-Ready: Maksim Ivanov <emaxx@chromium.org> Tested-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/663e1902e8359a5fdf4de75d78e1fc155ae7872e/cryptohome/signature_sealing_backend_test_utils.cc
,
Jul 12
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by vapier@chromium.org
, Jun 28 2018