unable to close wallaper picker with touch on fullscreen mode |
||
Issue descriptionChrome OS 10825.0.0, 69.0.3475.0 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1)Open wallpaper picker (2)Switch to fullscreen mode (3)tap on close button What is the expected result? What happens instead? Wallaper picker is not closed with touch. reprod 3/5 times. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62daa3a6aa5e737220cf83a5106cbb43cc9bee9b commit 62daa3a6aa5e737220cf83a5106cbb43cc9bee9b Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Jun 29 18:58:21 2018 cros: Fix several accessibility issues on wallpaper picker A combination of several small fixes: 1) Use the image title as the aria-label of each image. 2) Add role attribute to all buttons. 3) The "Explore" button should be hidden when the url is empty. 4) Enable selecting the entire image collection by using Tab key only (previously user has to use the up and down arrows). Bug: 779449, 857585 , 857567 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I36d2a15de494ad4294d67aab15e897d69b9c3faa Reviewed-on: https://chromium-review.googlesource.com/1119645 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#571575} [modify] https://crrev.com/62daa3a6aa5e737220cf83a5106cbb43cc9bee9b/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css [modify] https://crrev.com/62daa3a6aa5e737220cf83a5106cbb43cc9bee9b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js [modify] https://crrev.com/62daa3a6aa5e737220cf83a5106cbb43cc9bee9b/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js [modify] https://crrev.com/62daa3a6aa5e737220cf83a5106cbb43cc9bee9b/chrome/browser/resources/chromeos/wallpaper_manager/main.html
,
Jun 29 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by wzang@chromium.org
, Jun 28 2018Owner: wzang@chromium.org
Status: Started (was: Untriaged)