Support error bubble in view login |
||||
Issue descriptionIn some cases, like active directory authentication, we use the js bubble[1] instead of the error bubble in views, and because the js error bubble is placed in the left of the dialog, while in views we set the widget bounds to be exactly the bounds of the dialog, so the js bubble is not shown in this case. See screenshot(I hacked the code to be in active directory auth flow so the dialog might not be what it should look like in the real case). We should investigate how to support this case in views login. [1]: https://cs.chromium.org/chromium/src/ui/login/display_manager.js?rcl=c7f90e8d83c514cec3e3ca71e4cf76655476fca2&l=1143
,
Jun 28 2018
With CL: https://chromium-review.googlesource.com/c/chromium/src/+/1119498 it looks like the following in both views and webui login screen.
,
Jun 29 2018
,
Jun 29 2018
elizabethchiu@ any preference on the error bubble location in the screenshots above? Their positioning seems to have been broken at one point // views-login requires they be within the bubble. If the UX intended them to be outside we can take another look.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9a2ebc6b3eab7f124f9016460520c8864d1472e commit d9a2ebc6b3eab7f124f9016460520c8864d1472e Author: Sarah Hu <xiaoyinh@chromium.org> Date: Fri Jun 29 23:18:17 2018 Adjust error bubble position so it's shown in both views and webui login. Bug: 857583 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1d66cba765f9d68e913136e01c47f608d243ff76 Reviewed-on: https://chromium-review.googlesource.com/1119498 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#571703} [modify] https://crrev.com/d9a2ebc6b3eab7f124f9016460520c8864d1472e/chrome/browser/resources/chromeos/login/screen_active_directory_password_change.js [modify] https://crrev.com/d9a2ebc6b3eab7f124f9016460520c8864d1472e/chrome/browser/resources/chromeos/login/screen_gaia_signin.js [modify] https://crrev.com/d9a2ebc6b3eab7f124f9016460520c8864d1472e/ui/login/bubble.css
,
Jun 29 2018
,
Jun 29 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xiaoyinh@chromium.org
, Jun 28 2018