createImageBitmap tests fail after fixing JS variable shadowing errors |
||
Issue descriptionThree createImageBitmap color-space tests use a helper function to verify multiple tests over multiple pixel components. They all re-use loop variables, resulting in the tests only checking a small subset of their inputs. Fixing these bugs caused all the tests to fail. fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html fast/canvas/color-space/canvas-createImageBitmap-p3.html fast/canvas/color-space/canvas-createImageBitmap-rec2020.html I'm planning to fix the JS and disable these tests in TestExpectations (change incoming).
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d322114b3209437c8db53005eb23c2ad3d26a098 commit d322114b3209437c8db53005eb23c2ad3d26a098 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Thu Jun 28 21:51:18 2018 Fix color managed createImageBitmap test failures TBR=fserb@chromium.org Bug: 857576 Change-Id: Ie09bb209328a8fe54d23e8d069b9fd744bbc9cfa Reviewed-on: https://chromium-review.googlesource.com/1119159 Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571279} [modify] https://crrev.com/d322114b3209437c8db53005eb23c2ad3d26a098/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d322114b3209437c8db53005eb23c2ad3d26a098/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html [modify] https://crrev.com/d322114b3209437c8db53005eb23c2ad3d26a098/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-p3.html [modify] https://crrev.com/d322114b3209437c8db53005eb23c2ad3d26a098/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-rec2020.html
,
Jul 3
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 28 2018