New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 857542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 732555



Sign in to add a comment

Ensure Android OOP-D Maintains CompositorLock behavior

Project Member Reported by ericrk@chromium.org, Jun 28 2018

Issue description

Currently we allow for fairly long delays waiting for all surfaces to come in in two cases:

1) Resume from background - wait up to 5s
2) rotate screen - wait up to 2s

We should maintain this with Viz/OOP-D
 
Ahh this hsould just be a matter of upping the surface sync deadline.
I was wrong...I think we also need to allocate a new LocalSurfaceId for the UI anytime resume or rotate happens.
Cc: samans@chromium.org
Owner: fsam...@chromium.org
fsamuel@ is taking a look.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99ec37a96ac67df53307ddf437bd170cd7be2b24

commit 99ec37a96ac67df53307ddf437bd170cd7be2b24
Author: Fady Samuel <fsamuel@chromium.org>
Date: Mon Jul 16 21:43:47 2018

Surface synchronization: Use longer deadlines when appropriate

When surface synchronization is off, we lock the UI compositor on
Android during the first frame and resize in order to avoid producing
a CompositorFrame until the renderer has an appropriate frame ready.

Prior to this CL, with surface sync on, we used the default deadline
for synchronization. With this CL, we use the same deadlines that were
used prior to surface sync on versions of Android O or newer.

On versions older than O, we set the deadline for resize to 0.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Idb8f2b3891a9ae1bd43be4d81dbec3ccdb5ff436
Bug:  672962 ,  857542 
Reviewed-on: https://chromium-review.googlesource.com/1132324
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575436}
[modify] https://crrev.com/99ec37a96ac67df53307ddf437bd170cd7be2b24/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/99ec37a96ac67df53307ddf437bd170cd7be2b24/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/99ec37a96ac67df53307ddf437bd170cd7be2b24/ui/android/delegated_frame_host_android.h

Status: Fixed (was: Assigned)

Sign in to add a comment