New issue
Advanced search Search tips

Issue 857524 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-07-03
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in TemplateURLRef::SearchTermsArgs::SearchTermsArgs

Project Member Reported by ClusterFuzz, Jun 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5157820945924096

Fuzzer: dstockwell-anim-gen
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x1238d01d3190
Crash State:
  TemplateURLRef::SearchTermsArgs::SearchTermsArgs
  AutocompleteMatch::AutocompleteMatch
  OmniboxView::OpenMatch
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=570224:570233

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5157820945924096

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 28 2018

Components: UI>Browser>Omnibox UI>Browser>Search
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 28 2018

Labels: Test-Predator-Auto-Owner
Owner: jamescook@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/18be5ab85d10bc0768c8fad00d898c5adc647208 (views: Extract MusViewsDelegate to its own file).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: kylixrd@chromium.org
Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Untriaged (was: Assigned)
Nope, this is the 4th time I've been incorrectly blamed for this.

Cc: mpearson@google.com

Comment 5 by aarya@google.com, Jun 28 2018

Cc: -kylixrd@chromium.org
Labels: Pri-0
Owner: kylixrd@chromium.org
Status: Assigned (was: Untriaged)
This bug is flaky on windows and keeps getting closed. Please look at fixing this regression.
NextAction: 2018-07-03
Project Member

Comment 8 by sheriffbot@chromium.org, Jun 29 2018

Labels: M-69 Target-69
Project Member

Comment 9 by sheriffbot@chromium.org, Jun 29 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 29 2018

Labels: -Pri-0 Pri-1
Project Member

Comment 11 by ClusterFuzz, Jul 3

ClusterFuzz has detected this issue as fixed in range 572089:572090.

Detailed report: https://clusterfuzz.com/testcase?key=5157820945924096

Fuzzer: dstockwell-anim-gen
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x1238d01d3190
Crash State:
  TemplateURLRef::SearchTermsArgs::SearchTermsArgs
  AutocompleteMatch::AutocompleteMatch
  OmniboxView::OpenMatch
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=570224:570233
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=572089:572090

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5157820945924096

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jul 3

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5157820945924096 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
The NextAction date has arrived: 2018-07-03
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 3

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 16 by sheriffbot@chromium.org, Oct 9

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment