external/.../Accelerometer-iframe-access.https.html in webkit_layout_tests failing on chromium.mac/Mac10.10 Tests |
|||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yigu@chromium.org external/.../Accelerometer-iframe-access.https.html in webkit_layout_tests failing on chromium.mac/Mac10.10 Tests Builders failed on: - Mac10.10 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests The following layout test is flaky on Mac external/wpt/accelerometer/Accelerometer-iframe-access.https.html See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=external%2Fwpt%2Faccelerometer%2FAccelerometer-iframe-access.https.html&testType=webkit_layout_tests Test result diff: --- e:\b\s\w\iou7qozw\layout-test-results\external/wpt/accelerometer/Accelerometer-iframe-access.https-expected.txt +++ e:\b\s\w\iou7qozw\layout-test-results\external/wpt/accelerometer/Accelerometer-iframe-access.https-actual.txt @@ -1,9 +1,9 @@ This is a testharness.js-based test. PASS Accelerometer: sensor is suspended and resumed when focus traverses from to cross-origin frame -PASS Accelerometer: sensor is not suspended when focus traverses from to same-origin frame -PASS LinearAccelerationSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame -PASS LinearAccelerationSensor: sensor is not suspended when focus traverses from to same-origin frame -FAIL GravitySensor: sensor is suspended and resumed when focus traverses from to cross-origin frame assert_true: expected true got false -FAIL GravitySensor: sensor is not suspended when focus traverses from to same-origin frame assert_true: expected true got false +FAIL Accelerometer: sensor is not suspended when focus traverses from to same-origin frame assert_true: Not expecting event, but got reading event expected true got false +FAIL LinearAccelerationSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame promise_test: Unhandled rejection with value: object "Error: Call reset() before initialize()." +FAIL LinearAccelerationSensor: sensor is not suspended when focus traverses from to same-origin frame promise_test: Unhandled rejection with value: object "Error: Call reset() before initialize()." +FAIL GravitySensor: sensor is suspended and resumed when focus traverses from to cross-origin frame promise_test: Unhandled rejection with value: object "Error: Call reset() before initialize()." +FAIL GravitySensor: sensor is not suspended when focus traverses from to same-origin frame promise_test: Unhandled rejection with value: object "Error: Call reset() before initialize()." Harness: the test ran to completion.
,
Jun 28 2018
Alexander, could you please take a look?
,
Jun 28 2018
yigu@: What was the reason for the Site Isolation label? I don't see a connection yet.
,
Jun 28 2018
It was suggested by crbug.com and the failure was from a test with iframe so I applied the label. Feel free to update it if it's not related.
,
Jun 28 2018
Thanks. Removing the label since I don't think it's relevant in this case. Sounds more like Sensor and WebVR (from r566096 / issue 849501 ).
,
Jun 28 2018
,
Jun 28 2018
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ab4747c505da8a8c6bc8d1c2a68c9823c079b87 commit 6ab4747c505da8a8c6bc8d1c2a68c9823c079b87 Author: Yi Gu <yigu@chromium.org> Date: Thu Jun 28 21:11:32 2018 Update test expectation for external/wpt/accelerometer/Accelerometer-iframe-access.https.html TBR=carlosk@chromium.org NOTRY=true Bug: 857520 Change-Id: I319bf632a140514597272287a28682c84e38ffad Reviewed-on: https://chromium-review.googlesource.com/1119196 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571260} [modify] https://crrev.com/6ab4747c505da8a8c6bc8d1c2a68c9823c079b87/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a4c785d881fc0310750292388032bc1fb48eab5 commit 1a4c785d881fc0310750292388032bc1fb48eab5 Author: Yi Gu <yigu@chromium.org> Date: Thu Jun 28 22:23:27 2018 Update test expectation for external/wpt/accelerometer/Accelerometer-iframe-access.https.html TBR=carlosk@chromium.org NOTRY=true Bug: 857520 Change-Id: I2326fc9bbce2224b1c8123e6a91125905b4d5235 Reviewed-on: https://chromium-review.googlesource.com/1119350 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571298} [modify] https://crrev.com/1a4c785d881fc0310750292388032bc1fb48eab5/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 29 2018
I'm investigating this in connection with bug 855222
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d546214914c3d19541c9bd437676ee40aa2a1105 commit d546214914c3d19541c9bd437676ee40aa2a1105 Author: Yi Gu <yigu@chromium.org> Date: Fri Jun 29 18:16:13 2018 Mark Accelerometer-iframe-access.https.html failure on Win10 TBR=carlosk@chromium.org NOTRY=true Bug: 857520 Change-Id: I5ac3dd6a38f7000c82d8e17545bf6d5463501560 Reviewed-on: https://chromium-review.googlesource.com/1120857 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571550} [modify] https://crrev.com/d546214914c3d19541c9bd437676ee40aa2a1105/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6829d566966918236ca17eeb5c41e4eeb6b58dbc commit 6829d566966918236ca17eeb5c41e4eeb6b58dbc Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Fri Jul 06 20:46:30 2018 sensors: Fix flakiness in the same-origin access check tests Commit f73dfaffe ("[sensors] Check that sensor frame and focused frame of same origin") added a few same-origin access check tests for sensors in generic-sensor-iframe-tests.sub.js. The test that checks that a sensor is not suspended when focus changes to another same-origin frame was flaky though, especially on the Mac bots. The actual fix is a one-liner: we were missing a call to Sensor.stop() so that the sensor in the top-level document wouldn't continue to push 'reading' events to our EventWatcher while we were waiting for the "is_sensor_suspended" command to be processed in iframe_sensor_handler.html. I'm also taking the opportunity to make a few other minor improvements: * Fix a few typos in the comments, and improve the comment explaining why we can end up sending more "reading" events than originally expected. * Create the sensor belonging to the top-level document with a higher frequency than the default 5Hz. This makes it a lot easier to reproduce the error we were having and will hopefully make the test consistently fail in the future instead of being flaky should another related bug occur. * Make the EventWatcher instances we create also watch for "error" events; if an error event ever gets sent, the test should now fail instead of just timing out waiting for a "reading" event that is never delivered. Bug: 855222 , 857520 Change-Id: I945bb19d74e608089aa9aee82a4e74e05fae37ae Reviewed-on: https://chromium-review.googlesource.com/1127048 Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573062} [modify] https://crrev.com/6829d566966918236ca17eeb5c41e4eeb6b58dbc/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/6829d566966918236ca17eeb5c41e4eeb6b58dbc/third_party/WebKit/LayoutTests/external/wpt/generic-sensor/generic-sensor-iframe-tests.sub.js [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/mac-mac10.10/external/wpt/accelerometer/Accelerometer-iframe-access.https-expected.txt [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/mac-mac10.11/external/wpt/orientation-sensor/AbsoluteOrientationSensor-iframe-access.https-expected.txt [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/mac-mac10.12/external/wpt/accelerometer/Accelerometer-iframe-access.https-expected.txt [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/mac-mac10.12/external/wpt/orientation-sensor/AbsoluteOrientationSensor-iframe-access.https-expected.txt [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/accelerometer/Accelerometer-iframe-access.https-expected.txt [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/mac/external/wpt/accelerometer/Accelerometer-iframe-access.https-expected.txt [delete] https://crrev.com/5245a2a060f4e6b0ce1e2913de8da57b392f8263/third_party/WebKit/LayoutTests/platform/win7/external/wpt/accelerometer/Accelerometer-iframe-access.https-expected.txt
,
Jul 6
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 28 2018