FYI the code for views-based shelf is in login_shelf_view.cc

Somehow I couldn't repro on ToT: both webui and views does not show guest button when the signin dialog is shown.

See screenshot below, and looks like the app button visibility is not consistent in views vs webui, I will upload a CL to fix this.


 

Deleted: guest_button_webui.png 36.6 KB

	guest_button_webui.png 36.6 KB View Download

Deleted: guest_button_views.png 37.0 KB

	guest_button_views.png 37.0 KB View Download

Just tried on 69.0.3493.0. The issue reproduces when there are no users on the device (thus no pods).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9

commit fa0ab3e4d807f864ff1b808a2f27ed58370eeae9
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Wed Jul 25 18:15:47 2018

cros: Update visibility of guest and apps button in the shelf.

Bug:  857514 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I6ca7211bcf811b57fb03f5fe275c6c2600e654ee
Reviewed-on: https://chromium-review.googlesource.com/1142384
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577977}
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/ash/login/login_screen_controller.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/ash/login/login_screen_controller.h
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/resources/chromeos/login/md_header_bar.js
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/fa0ab3e4d807f864ff1b808a2f27ed58370eeae9/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

The above CL has been reverted since the add user button was not showing up correctly. 
Re-open this bug to investigate the cause.

 Issue 872848  has been merged into this issue.

Issue 874268 has been merged into this issue.

I can repro this issue in M-70 (ToT), it works correctly in M-69 (see attached screenshots).

In CPanel set DeviceGuestModeEnabled=true, DeviceShowUserNamesOnSignin=false, no Public Session.

Steps:

(1) Enroll device to domain <- "Browse as Guest" option is available on the Sign-in screen
(2) Sign-in as user, sign-out <- "Browse as Guest" option is not available on the Sign-in screen

or

(1) Enroll device to domain <- "Browse as Guest" option is available on the Sign-in screen
(2) Sign-in as Guest, sign-out <- "Browse as Guest" option is not available on the Sign-in screen

Deleted: Screenshot M-69.png 875 KB

	Screenshot M-69.png 875 KB View Download

Deleted: Screenshot M-70.png 696 KB

	Screenshot M-70.png 696 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d19d3c6952f249250172ae9631002f3992fc63

commit 51d19d3c6952f249250172ae9631002f3992fc63
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Mon Aug 27 19:41:50 2018

Reland: cros: Update visibility of guest and apps button in the shelf.

PatchSet 1 is originally reviewed in
https://chromium-review.googlesource.com/c/chromium/src/+/1142384

On top of the original CL, this updates the following:
1. Notify oobe dialog state based on the visibility of the oobe dialog.
2. Send additional data SetShowGuestButtonForGaiaScreen to login shelf.

Bug:  857514 ,  869811 
Change-Id: Ic8baae2e31d2818f356e7fc79f172e4091053fec
Reviewed-on: https://chromium-review.googlesource.com/1168105
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586373}
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller_observer.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/login_screen_controller_observer.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/login_display_mojo.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/resources/chromeos/login/md_header_bar.js
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/51d19d3c6952f249250172ae9631002f3992fc63/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h

Checked on Google Chrome:70.0.3532.0 Platform:11021.0.0 robo

Observation:
Guest button shown on login UI and Footer after device Enroll 
Guest button not shown on Footer after exiting Guest mode/User login.

Attached screenshots.

Deleted: Screenshot 2018-08-31 at 3.57.11 PM.png 53.7 KB

	Screenshot 2018-08-31 at 3.57.11 PM.png 53.7 KB View Download

Deleted: Screenshot 2018-08-31 at 3.58.44 PM.png 577 KB

	Screenshot 2018-08-31 at 3.58.44 PM.png 577 KB View Download

chchakrapani@, CL in comment#13 was landed in 70.0.3535.0, could you help to double check the latest build?

Sure. Will re-verify it.

Guest button shown on footer on User login/exiting Guest mode.
Google Chrome: 70.0.3538.14 Platform: 11021.11.0 robo

Hence,closing the bug as verified.

Deleted: Screenshot 2018-09-10 at 2.14.54 PM.png 55.6 KB

	Screenshot 2018-09-10 at 2.14.54 PM.png 55.6 KB View Download

Deleted: Screenshot 2018-09-10 at 2.15.36 PM.png 535 KB

	Screenshot 2018-09-10 at 2.15.36 PM.png 535 KB View Download

[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.

Fix in Comment 13 is landed before branch, so no need to merge.