Toolbar first draw and focus UMAs are being double reported |
||
Issue descriptionMobileStartup.ToolbarFirstDrawTime and MobileStartup.ToolbarFirstFocusTime are being double reported. The UMAs are meant to be recorded if the event happens during the first 30s of startup. However due to a missing return statement in ToolbarManager#onDeferredStartup after the delayed task (30s after startup) is posted, the histograms are recorded twice. Once during the first run that posts the delayed task and again once the delayed task is actually run.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e321425b0d2320a982e9f27a3d5617f53742a98f commit e321425b0d2320a982e9f27a3d5617f53742a98f Author: Mohamed Heikal <mheikal@google.com> Date: Thu Jun 28 21:52:02 2018 [UMA] Fix double reporting ToolbarFirst*Time histogram + rename Fix bug where MobileStartup.ToolbarFirstDrawTime.<activity name> and MobileStartup.ToolbarFirstFocusTime.<activity name> were being double reported. Also rename aforementioned histograms to MobileStartup.ToolbarFirstDrawTime2.<activity name> and MobileStartup.ToolbarFirstFocusTime2.<activity name> respectively after the bug fix. Bug: 857508 Change-Id: I32f401a0a63df37f6fad2f781cb5e6598abb4a34 Reviewed-on: https://chromium-review.googlesource.com/1118749 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#571280} [modify] https://crrev.com/e321425b0d2320a982e9f27a3d5617f53742a98f/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/e321425b0d2320a982e9f27a3d5617f53742a98f/tools/metrics/histograms/histograms.xml
,
Jul 5
I am closing this as fixed. |
||
►
Sign in to add a comment |
||
Comment 1 by mheikal@chromium.org
, Jun 28 2018