New issue
Advanced search Search tips

Issue 857504 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 855791



Sign in to add a comment

GN cipd switch broke internal repos

Project Member Reported by scottmg@chromium.org, Jun 28 2018

Issue description

sdefresne from https://groups.google.com/a/chromium.org/d/topic/gn-dev/8VxjhCdawzE/discussion
=====

Hi Scott,

This probably broke every project based on Chromium that fetches src/ via a recurse_deps due to how the gn wrapper works [1]. What those projects usually do is to fetch their repository in a sub-directory of src/, say src/$internal/, and use a recurse_deps in src/$internal/DEPS to fetch src/. Both iOS and Android internal repositories at Google are set up this way, and from the email thread, it appears this may also be the case for Chrome OS. Branch builds using buildspec are also setup this way (but this may have changed, I've not build a branch for some time).

For those affected (i.e. people working on downstream iOS, Android, Chrome OS repositories), a quick workaround is to create a symlink from src/$internal/third_party/gn pointing to src/third_party/gn.

=======

I'm not sure what the right fix is here. I guess we'll need to make gn.py even more complicated.
 
Clank appears to have been fixed by doing https://chrome-internal.googlesource.com/clank/internal/apps/+/de0bd7a88ceba9686a25547ce288d4f993c4fbf3 (a symlink to the expected location was checked in) for other repos experiencing the same problem.
Blocking: 855791

Sign in to add a comment