New issue
Advanced search Search tips

Issue 857501 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] link highlights do not paint

Project Member Reported by pdr@chromium.org, Jun 28 2018

Issue description

Link highlights are special and currently do not paint:
third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees compositing/gestures/gesture-tapHighlight*

The immediate failure is that link highlight layers are not send to cc. The link highlight implementation is bad and it's not clear what changes are required to get them working with blink gen property trees. We should pick an approach that will work for SPV2 as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01a1cbea66c6b3cebb2c5a23e0b2e186b155d069

commit 01a1cbea66c6b3cebb2c5a23e0b2e186b155d069
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Jul 02 21:03:47 2018

Remove unused link highlight clip layer

Link highlights have two cc::Layers: one for clipping and one for the
contents. The clip layer is unused today and may have never been
implemented (see: original patch without clip support [1]).

[1] https://chromium.googlesource.com/chromium/src/+/7baf240818b3b0c1be0ea64209881b8cebded493

Bug:  857501 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1261c1ccbb9b81534ca0db5bcbc369d73ca00173
Reviewed-on: https://chromium-review.googlesource.com/1121694
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571995}
[modify] https://crrev.com/01a1cbea66c6b3cebb2c5a23e0b2e186b155d069/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/01a1cbea66c6b3cebb2c5a23e0b2e186b155d069/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/01a1cbea66c6b3cebb2c5a23e0b2e186b155d069/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50

commit 627c36a46a1b033c7a56dc27b1e964d4f9a4ea50
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Jul 03 18:07:17 2018

Enable gesture tap highlight tests on mac

These were disabled in https://codereview.chromium.org/34353004 but
now run. The setting, multiTargetTapNotificationEnabled, is enabled on
all platforms.

This patch unskips the gesture tap highlight tests on mac and updates
their expectations.

Bug:  857501 
Change-Id: I4bb6c91cd5b75d3fe30420759073f404a62d896f
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1121786
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572293}
[modify] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/platform/mac/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[add] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/platform/mac/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png
[add] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/platform/mac/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png
[add] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/platform/mac/compositing/gestures/gesture-tapHighlight-skew-matrix-expected.png
[add] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/platform/mac/compositing/gestures/gesture-tapHighlight-with-box-shadow-expected.png
[add] https://crrev.com/627c36a46a1b033c7a56dc27b1e964d4f9a4ea50/third_party/WebKit/LayoutTests/platform/mac/compositing/gestures/gesture-tapHighlight-with-squashing-expected.png

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5720a93cee49079b44e4d688293265c125c98dd6

commit 5720a93cee49079b44e4d688293265c125c98dd6
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Jul 04 00:53:35 2018

LayoutTests: Mark a few tests in compositing/gestures/ as flaky

These were enabled at crrev.com/c/1121786 but still a few tests are failing on
Mac10.10 Tests bot.

TBR=pdr@chromium.org
NOTRY=true

Bug:  857501 
Change-Id: I20542f3c38550de579db0304c9d27be8e67e5cc8
Reviewed-on: https://chromium-review.googlesource.com/1124729
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572411}
[modify] https://crrev.com/5720a93cee49079b44e4d688293265c125c98dd6/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5e9158a853ade75612073e9535af7f1c7949c4d

commit a5e9158a853ade75612073e9535af7f1c7949c4d
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Jul 04 01:11:56 2018

Mark tests flaky only on Mac10.10

crrev.com/c/1124729 marks a few tests as flaky on Mac, but this replaces it to
Mac10.10, which is more restrictive.

TBR=pdr@chromium.org
NOTRY=true

Bug:  857501 
Change-Id: Ibca47cd41a2ec17b95372ea115081f08312217ba
Reviewed-on: https://chromium-review.googlesource.com/1124731
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572421}
[modify] https://crrev.com/a5e9158a853ade75612073e9535af7f1c7949c4d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3

commit 7f3975eb2b5b5416d5299eaacffa0e4aadce23d3
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Jul 05 15:10:46 2018

[BlinkGenPropertyTrees] Move link highlights from WebViewImpl to Page

Link highlights are currently owned by the WebViewImpl so their updates
(creation, deletion, layout, paint) happen entirely outside the main
LocalFrameView update lifecycle. In BlinkGenPropertyTrees we will need
to create foreign layers for link highlights which needs to happen after
the link highlight update (LinkHighlightImpl::UpdateGeometry) but before
blink does the cc update (PaintArtifactCompositor::Update). This patch
moves link highlights from WebViewImpl to Page which will let us manage
their lifecycle from the main blink lifecycle update.

This patch does not fix the issue of link highlights getting painted via
a cc paint callback, which will need to be fixed for SPV2, but this does
move us closer towards that goal.

Bug:  857501 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I313ef453234ff5a79337208c2acfc7d6c9cb3c94
Reviewed-on: https://chromium-review.googlesource.com/1123315
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572796}
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/frame/BUILD.gn
[add] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/frame/link_highlights.cc
[add] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/frame/link_highlights.h
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/page/page.h
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/7f3975eb2b5b5416d5299eaacffa0e4aadce23d3/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed4090b54cf0552ae2cf0239a399769e0c3a541e

commit ed4090b54cf0552ae2cf0239a399769e0c3a541e
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Jul 05 16:30:45 2018

Update Mac10.10 compositing/gestures expectations

My original patch [1] had incorrect baselines for Mac10.10 which was not
caught by the CQ. These tests were then marked flaky [2]. This patch
updates the baselines using the Mac10.10 bot results.

[1] https://crrev.com/572293
[2] https://crrev.com/572421

Bug:  857501 
Change-Id: Ideaec3d29f73c9116bf0488df595dc3b6d7487cb
Reviewed-on: https://chromium-review.googlesource.com/1127149
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572814}
[modify] https://crrev.com/ed4090b54cf0552ae2cf0239a399769e0c3a541e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/ed4090b54cf0552ae2cf0239a399769e0c3a541e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/gestures/gesture-tapHighlight-pixel-rotated-div-expected.png
[add] https://crrev.com/ed4090b54cf0552ae2cf0239a399769e0c3a541e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/gestures/gesture-tapHighlight-pixel-rotated-link-expected.png
[add] https://crrev.com/ed4090b54cf0552ae2cf0239a399769e0c3a541e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/gestures/gesture-tapHighlight-pixel-transparent-expected.png

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/025f5dc7ac9c73bd892d8519f192283b57e6015d

commit 025f5dc7ac9c73bd892d8519f192283b57e6015d
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 06 13:39:03 2018

Revert "[BlinkGenPropertyTrees] Move link highlights from WebViewImpl to Page"

This reverts commit 7f3975eb2b5b5416d5299eaacffa0e4aadce23d3.

Reason for revert: Broke highlight fading, see: https://crbug.com/860613

Original change's description:
> [BlinkGenPropertyTrees] Move link highlights from WebViewImpl to Page
> 
> Link highlights are currently owned by the WebViewImpl so their updates
> (creation, deletion, layout, paint) happen entirely outside the main
> LocalFrameView update lifecycle. In BlinkGenPropertyTrees we will need
> to create foreign layers for link highlights which needs to happen after
> the link highlight update (LinkHighlightImpl::UpdateGeometry) but before
> blink does the cc update (PaintArtifactCompositor::Update). This patch
> moves link highlights from WebViewImpl to Page which will let us manage
> their lifecycle from the main blink lifecycle update.
> 
> This patch does not fix the issue of link highlights getting painted via
> a cc paint callback, which will need to be fixed for SPV2, but this does
> move us closer towards that goal.
> 
> Bug:  857501 
> Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I313ef453234ff5a79337208c2acfc7d6c9cb3c94
> Reviewed-on: https://chromium-review.googlesource.com/1123315
> Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572796}

TBR=trchen@chromium.org,pdr@chromium.org

Change-Id: I15f71b1377967bf0c6bc6258faaaf6636b04a9e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  857501 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1127959
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572957}
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/frame/BUILD.gn
[delete] https://crrev.com/4e4858ce7b5a2d4556e795be7d69bf67ebc83451/third_party/blink/renderer/core/frame/link_highlights.cc
[delete] https://crrev.com/4e4858ce7b5a2d4556e795be7d69bf67ebc83451/third_party/blink/renderer/core/frame/link_highlights.h
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/page/page.h
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/025f5dc7ac9c73bd892d8519f192283b57e6015d/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059

commit e84ec47c42c1f55d1456b9decc5a7cf5e86fa059
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Jul 17 00:58:50 2018

Reland: [BGPT] Move link highlights from WebViewImpl to Page

This is a reland of [1] with a fix for animations not starting. This
patch adds a CompositorAnimationHost to LinkHighlights, similar to how
ScrollingCoordinator works, so that the link highlight timeline is
connected to an animation host. A basic test has been added.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1123315

Link highlights are currently owned by the WebViewImpl so their updates
(creation, deletion, layout, paint) happen entirely outside the main
LocalFrameView update lifecycle. In BlinkGenPropertyTrees we will need
to create foreign layers for link highlights which needs to happen after
the link highlight update (LinkHighlightImpl::UpdateGeometry) but before
blink does the cc update (PaintArtifactCompositor::Update). This patch
moves link highlights from WebViewImpl to Page which will let us manage
their lifecycle from the main blink lifecycle update.

This patch does not fix the issue of link highlights getting painted via
a cc paint callback, which will need to be fixed for SPV2, but this does
move us closer towards that goal.

Bug:  857501 
Change-Id: I921594484f7b41844b3e2b49c6ef79458f0e7c5b
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1134413
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575501}
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/frame/BUILD.gn
[add] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/frame/link_highlights.cc
[add] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/frame/link_highlights.h
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/page/page.h
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/e84ec47c42c1f55d1456b9decc5a7cf5e86fa059/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb4e57d56e478c5c7982bff819cf427f41dfd7a

commit fcb4e57d56e478c5c7982bff819cf427f41dfd7a
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Jul 24 05:06:02 2018

[BlinkGenPropertyTrees] Record link highlights as foreign layers

This patch makes link highlights draw using foreign layers. To achieve this,
link highlights have been more tightly integrated into the blink lifecycle.
There are five big changes:

1) With BlinkGenPropertyTrees, link highlights paint above all other content
and without inherited effects. This will be better UX, and it resolves an
issue where link highlight painting could change painting in a subtle way.

2) Link highlight animations require an effect paint property node so a new
effect node is now created/updated on LayoutObjects that have link highlights.
When link highlights are added or removed, we now mark the associated layout
object as needing a paint property update.

3) LinkHighlights::UpdateGeometry has been moved from
WebViewImpl::UpdateLifecycle to LocalFrameView::PaintTree. This ensures link
highlight layers are created/updated before the drawable layers are collected.

4) CollectLinkHighlightLayersForLayerListRecursively now collects link highlight
layers, associates them with the link highlight effect node, and creates foreign
layers for them. Because there can be multiple highlights, LinkHighlight has
been made a DisplayItemClient to ensure the foreign layer ids are unique.

5) LinkHighlightImplTest has been parameterized to run with and without
BlinkGenPropertyTrees which required some refactoring to ensure the test
teardown occurred while the BlinkGenPropertyTrees setting was in scope.

This change does not remove the GraphicsLayer dependency of the link highlight
implementation, which will be required for SPV2, but it moves the implementation
much closer to a SPV2-compatible design.

BUG= 857501 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8ed54a56b4cb23ae581e8a848db921baf09afcce
Reviewed-on: https://chromium-review.googlesource.com/1125295
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577431}
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-with-filter-expected.html
[add] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/WebKit/LayoutTests/compositing/gestures/gesture-tapHighlight-with-filter.html
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/frame/link_highlights.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/frame/link_highlights.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/paint/find_properties_needing_update.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/paint/link_highlight_impl.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/paint/object_paint_properties.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/platform/graphics/graphics_layer.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/platform/graphics/link_highlight.h
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/platform/graphics/paint/display_item.cc
[modify] https://crrev.com/fcb4e57d56e478c5c7982bff819cf427f41dfd7a/third_party/blink/renderer/platform/graphics/paint/display_item.h

Status: Fixed (was: Assigned)

Sign in to add a comment