New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857495 link

Starred by 2 users
Status: Fixed
Owner:
fdoray@chromium.org
Closed: Jul 24
Cc:
q...@chromium.org
█ wwen@chromium.org
braveyao@chromium.org
posciak@chromium.org
windmueller@google.com
chrisha@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Hangouts is frozen/discarded while sharing the desktop

Project Member Reported by fdoray@chromium.org, Jun 28 2018 
Chrome Version: 69.0.3475.0
OS: Desktop

What steps will reproduce the problem?
(1) Start a screen share from https://hangouts.google.com/hangouts/_/present.
(2) Put the tab in the background (e.g. by minimizing the window).
(3) Wait 10 minutes.

What is the expected result?
The state of the tab remains active, not frozen or discarded (chrome://discards). Other participants in the Hangouts can still see updates to the screen.

What happens instead?
The state of the tab switches to frozen after 10 minutes, or to discarded after a few seconds if the number of tabs is >100 (chrome://discards). Other participants in the Hangouts see that the screen share ended.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65406f8f364de8d8c332db0a7e6b14cc6da8b902

commit 65406f8f364de8d8c332db0a7e6b14cc6da8b902
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Jul 06 16:11:07 2018

Track desktop capture in MediaStreamCaptureIndicator.

Today, MediaStreamCaptureIndicator keeps track of which WebContents
are capturing a video or audio device or another tab, but not of which
WebContents are capturing the desktop. This is problematic because
TabLifecycleUnit uses MediaStreamCaptureIndicator to decide which tabs
can be frozen/discarded.

With this CL:
- MediaStreamCaptureIndicator is notified of all stream captures,
  including desktop captures. An object can be provided to display
  custom UI when a stream is registered.
- MediaStreamCaptureIndicator exposes IsCapturingDesktop(), which
  can be used to determine whether a WebContents is capturing the
  desktop.

Future work:
- content::MediaStreamUI should be renamed
  content::MediaStreamDelegate, because it is an interface that
  allows an embedder to be notified when stream capture
  starts/stops, not just to display UI.
- MediaStreamCaptureIndicator should be renamed
  MediaStreamCaptureTracker, because it is not only used to display
  an indicator, it is a map from WebContents -> stream types.

TBR=elijahtaylor@chromium.org

Bug:  857495 
Change-Id: I5ac2c670b599ef9a5aa8968c5e0e385cacce9412
Reviewed-on: https://chromium-review.googlesource.com/1118613
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572982}
[modify] https://crrev.com/65406f8f364de8d8c332db0a7e6b14cc6da8b902/chrome/browser/chromeos/arc/screen_capture/arc_screen_capture_session.h
[modify] https://crrev.com/65406f8f364de8d8c332db0a7e6b14cc6da8b902/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/65406f8f364de8d8c332db0a7e6b14cc6da8b902/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
[modify] https://crrev.com/65406f8f364de8d8c332db0a7e6b14cc6da8b902/chrome/browser/media/webrtc/media_stream_capture_indicator.h
[modify] https://crrev.com/65406f8f364de8d8c332db0a7e6b14cc6da8b902/chrome/browser/ui/screen_capture_notification_ui.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c

commit 0537074d3c771f8aa9465ce02dfdd9dacf7ab47c
Author: Francois Doray <fdoray@chromium.org>
Date: Sat Jul 14 02:59:10 2018

RC: Do not freeze or discard tabs capturing the desktop.

With this CL, Hangouts should no longer be discarded during a
screenshare session.

See privacy doc update:
https://docs.google.com/a/google.com/document/d/1BNQ5nLOtPuwP7oxr9r-XKNKr5iObXEiA_69WXAvuYAo/edit?disco=AAAACBUojIc

Bug: 775644,  857495 
Change-Id: I2fa58efc58d1a9c92ae49c5eb308514722637c14
Reviewed-on: https://chromium-review.googlesource.com/1136513
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575141}
[modify] https://crrev.com/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c/chrome/browser/resource_coordinator/decision_details.cc
[modify] https://crrev.com/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c/chrome/browser/resource_coordinator/decision_details.h
[modify] https://crrev.com/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c/chrome/browser/resource_coordinator/decision_details_unittest.cc
[modify] https://crrev.com/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/0537074d3c771f8aa9465ce02dfdd9dacf7ab47c/tools/metrics/ukm/ukm.xml

Comment 3 by fdoray@chromium.org, Jul 24

Status: Fixed (was: Assigned)

Comment 4 by fdoray@chromium.org, Nov 23

Cc: fdoray@chromium.org posciak@chromium.org windmueller@google.com braveyao@chromium.org q...@chromium.org chrisha@chromium.org wwen@chromium.org
 Issue 817219  has been merged into this issue.
►

Sign in to add a comment