[ RUN      ] AllForms/FormStructureBrowserTest.DataDrivenHeuristics/48
../../components/autofill/core/browser/data_driven_test.cc:86: Failure
Expected equality of these values:
  output_file_contents
    Which is: "SEARCH_TERM | q | deviantARTBrowse ArtPrints ShopT-Shirts & GearFind More ArtDaily DeviationsDiscover |  | q_1-default\nEMAIL_ADDRESS | emailAddress | Email Address |  | emailAddress_1-default\nUNKNOWN_TYPE | password | Password |  | emailAddress_1-default\nUNKNOWN_TYPE | remember_me | Stay logged in | 1 | emailAddress_1-default\nUNKNOWN_TYPE | existingAccount | Create a new Buyer Account | 0 | existingAccount_1-default\nUNKNOWN_TYPE | existingAccount | I have an existing deviantART account (email or username) | 1 | existingAccount_1-default\nEMAIL_ADDRESS | emailAddress | Email Address |  | existingAccount_1-default\nUNKNOWN_TYPE | password | Password |  | existingAccount_1-default\nUNKNOWN_TYPE | remember_me | Stay logged in | 1 | existingAccount_1-default\nUNKNOWN_TYPE | passwordNew | Password |  | existingAccount_1-default\nUNKNOWN_TYPE | passwordConfirm | Password (confirm) |  | existingAccount_1-default\nNAME_FULL | name | Full Name |  | existingAccount_1-default\nADDRESS_HOME_COUNTRY | country | Country | 0 | existingAccount_1-default\n"
  output
    Which is: "SEARCH_TERM | q | deviantARTBrowse ArtPrints ShopT-Shirts & GearFind More ArtDaily DeviationsDiscover |  | q_1-default\nEMAIL_ADDRESS | emailAddress | Email Address |  | emailAddress_1-default\nUNKNOWN_TYPE | password | Password |  | emailAddress_1-default\nUNKNOWN_TYPE | remember_me | Stay logged in | 1 | emailAddress_1-default\nUNKNOWN_TYPE | existingAccount | Create a new Buyer Account | 0 | existingAccount_1-default\nUNKNOWN_TYPE | existingAccount | I have an existing deviantART account (email or username) | 1 | existingAccount_1-default\nEMAIL_ADDRESS | emailAddress | Email Address |  | existingAccount_1-default\nUNKNOWN_TYPE | password | Password |  | existingAccount_1-default\nUNKNOWN_TYPE | remember_me | Stay logged in | 1 | existingAccount_1-default\nUNKNOWN_TYPE | passwordNew | Password |  | existingAccount_1-default\nUNKNOWN_TYPE | passwordConfirm | Password (confirm) |  | existingAccount_1-default\nNAME_FULL | name | Full Name |  | existingAccount_1-default\nADDRESS_HOME_COUNTRY | country | Country | 0 | existingAccount_1-default\nSEARCH_TERM | q | deviantARTBrowse ArtPrints ShopT-Shirts & GearFind More ArtDaily DeviationsDiscover |  | q_1-default\nEMAIL_ADDRESS | emailAddress | Email Address |  | emailAddress_1-default\nUNKNOWN_TYPE | password | Password |  | emailAddress_1-default\nUNKNOWN_TYPE | remember_me | Stay logged in | 1 | emailAddress_1-default\nUNKNOWN_TYPE | existingAccount | Create a new Buyer Account | 0 | existingAccount_1-default\nUNKNOWN_TYPE | existingAccount | I have an existing deviantART account (email or username) | 1 | existingAccount_1-default\nEMAIL_ADDRESS | emailAddress | Email Address |  | existingAccount_1-default\nUNKNOWN_TYPE | password | Password |  | existingAccount_1-default\nUNKNOWN_TYPE | remember_me | Stay logged in | 1 | existingAccount_1-default\nUNKNOWN_TYPE | passwordNew | Password |  | existingAccount_1-default\nUNKNOWN_TYPE | passwordConfirm | Password (confirm) |  | existingAccount_1-default\nNAME_FULL | name | Full Name |  | existingAccount_1-default\nADDRESS_HOME_COUNTRY | country | Country | 0 | existingAccount_1-default\n"
With diff:

It's flaky and was seen in earlier build. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/34785

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b15b58d6f4c36eb41ab73d3bcc58c39db1ff08

commit f9b15b58d6f4c36eb41ab73d3bcc58c39db1ff08
Author: Yi Gu <yigu@chromium.org>
Date: Thu Jun 28 16:15:02 2018

ios_chrome_unittests (iPhone 6s Plus iOS 11.2) failing on chromium.mac/ios-simulator

TBR=jochen@chromium.org
NOTRY=true

Bug:  857488 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I36166c547f9c5c5b9d69d01742a20f6673c8f15e
Reviewed-on: https://chromium-review.googlesource.com/1118534
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571148}
[modify] https://crrev.com/f9b15b58d6f4c36eb41ab73d3bcc58c39db1ff08/ios/chrome/browser/autofill/form_structure_browsertest.mm

rogerm@, could you please take a look?

Hmm... that looks very much like the form output has been duplicated, as if the autofill manager has stored two instances of the form(s).

Looking at the earlier failure mentioned in comment 2...

  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/34785

the only autofill parsing related change was from vabr@

  https://chromium-review.googlesource.com/c/chromium/src/+/1116920

It doesn't look like an obvious culprit.

Strawman hypothesis...

The form_structure_browsertest suite doesn't explicitly disable server predictions. If the predictions arrive quickly enough, could that change the way the forms are parsed?
I.e., such that the post server response interpretation of the forms no longer appear to be the same forms as pre-server response? Yielding more than one "version" of the form known to the autofill manager?

Seems unlikely.

+mahmadi, +olivierrobin for iOS form extraction.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b1820da033559bd1d27e21552edc51260d5ab8b

commit 1b1820da033559bd1d27e21552edc51260d5ab8b
Author: Roger McFarlane <rogerm@chromium.org>
Date: Mon Jul 23 19:04:41 2018

[autofill] Add missing form_structure_browsertest cases to iOS

Tests 148 through 151 were not included in the test case bundle (copy
step for dependendent data) in the iOS build, so these tests were not
being run on that platform.

This CL adds the input and output files to the unit_tests_bundle_data.

Bug:  865864 , 857488 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib501fe2644c7961f2d6bcee80f7388a7daef8623
Reviewed-on: https://chromium-review.googlesource.com/1146769
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577214}
[modify] https://crrev.com/1b1820da033559bd1d27e21552edc51260d5ab8b/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/1b1820da033559bd1d27e21552edc51260d5ab8b/ios/chrome/browser/autofill/form_structure_browsertest.mm

Marking as fixed, as the problem seems to be resolved.