Remove unnecessary local/remote path component when installing Tast test data |
||
Issue description
Tast test data currently gets installed to /usr/share/tast/data/{local,remote}/<path>, where <path> is the file's path within the tast-tests repository's src/ directory (e.g. "chromiumos/tast/local/bundles/cros/example/data/foo_bar.txt" for a local test in the "cros" bundle with name "example.Foo").[1]
I initially added the local/remote path components for both test bundles and test data for issue 809185 , since local and remote test bundles are installed simultaneously in moblab builds. I think that the component is unnecessary for test data, though, as "local" or "remote" appears again later in the path -- there shouldn't be any risk of file collisions.
To shorten these paths, I think that test data should instead be installed at /usr/share/tast/data/<path>. I'll need to update the tast command to check whether to use new or old paths for a few months, similar to what I did when changing paths for issue 809185 .
1. The data actually ends up under /usr/local/share instead of /usr/share on DUT system images, meaning that "local" appears three times in the full path. :-/
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/059df7bb1dc341740c40fdcf388a5a3d93fd8f37 commit 059df7bb1dc341740c40fdcf388a5a3d93fd8f37 Author: Daniel Erat <derat@chromium.org> Date: Sat Jun 30 05:00:46 2018 autotest: Remove 'remote' dir from Tast data paths. Make the tast.py server test stop appending a 'remote' directory to paths passed to the tast executable's -remotedatadir flag. BUG= chromium:857485 , chromium:809185 TEST=see change to tast repository CQ-DEPEND=I46c2109e9683dd074ea8b0a123dfbd7704c80afc CQ-DEPEND=I4a699c07e259ad38c075e05751129be9877a7ed7 Change-Id: I252517e17c1ea0cd23aa7022e9c2a64c160d2a89 Reviewed-on: https://chromium-review.googlesource.com/1119421 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/059df7bb1dc341740c40fdcf388a5a3d93fd8f37/server/site_tests/tast/tast.py
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/330b522e2f1d5414aef5b4436c500dd233f296e4 commit 330b522e2f1d5414aef5b4436c500dd233f296e4 Author: Daniel Erat <derat@chromium.org> Date: Sat Jun 30 05:00:47 2018 tast: Remove local/remote components from builtin data dir. Update the tast executable, test runners, and test bundles to get test data from /usr/share/tast/data/<path> rather than /usr/share/tast/data/{local,remote}/<path> (or /usr/local/share/... in the case of files installed on DUTs). Data files for local tests are also pushed to /usr/local/share/tast/data_pushed rather than /usr/local/share/tast/data/local_pushed. The tast executable supports falling back to using /usr/local/share/tast/data/local for backwards compatibility with older system images. BUG= chromium:857485 , chromium:809185 TEST=unit tests pass; also ran tryjobs; also verified: - data files in built-in remote test - data files in pushed remote test - data files in pushed local test - data files in old location in pushed local test - data files in new location in pushed local test CQ-DEPEND=I4a699c07e259ad38c075e05751129be9877a7ed7 CQ-DEPEND=I252517e17c1ea0cd23aa7022e9c2a64c160d2a89 Change-Id: I46c2109e9683dd074ea8b0a123dfbd7704c80afc Reviewed-on: https://chromium-review.googlesource.com/1119422 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/330b522e2f1d5414aef5b4436c500dd233f296e4/src/chromiumos/tast/bundle/local.go [modify] https://crrev.com/330b522e2f1d5414aef5b4436c500dd233f296e4/src/chromiumos/cmd/tast/run/local.go [modify] https://crrev.com/330b522e2f1d5414aef5b4436c500dd233f296e4/src/chromiumos/cmd/tast/run/local_test.go [modify] https://crrev.com/330b522e2f1d5414aef5b4436c500dd233f296e4/src/chromiumos/cmd/tast/run/config.go [modify] https://crrev.com/330b522e2f1d5414aef5b4436c500dd233f296e4/src/chromiumos/cmd/local_test_runner/main.go [modify] https://crrev.com/330b522e2f1d5414aef5b4436c500dd233f296e4/src/chromiumos/cmd/remote_test_runner/main.go
,
Jun 30 2018
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast/+/0ba749310144c54e1fadbe06f859ecf87bd32fbd commit 0ba749310144c54e1fadbe06f859ecf87bd32fbd Author: Shuhei Takahashi <nya@chromium.org> Date: Wed Jan 09 17:38:48 2019 tast: Drop support of old data dir. BUG= chromium:857485 TEST=fast_build.sh -T Change-Id: Ic0a9efe3f89ba73c7cb9bec544d5bf0f5356cd04 Reviewed-on: https://chromium-review.googlesource.com/1401931 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/0ba749310144c54e1fadbe06f859ecf87bd32fbd/src/chromiumos/cmd/tast/run/local.go |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 30 2018