New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857465 link

Starred by 3 users
Status: Fixed
Owner:
█ reve...@chromium.org
Last visit > 30 days ago
Closed: Jul 3
Cc:
smbar...@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Missing shadows for X11 popups

Project Member Reported by reve...@chromium.org, Jun 28 2018 
Looks like some of our improvements to xdg popups made the shadows go away. The aura shell protocol set_frame request is likely ignored now.

This is probably fine as we can't use popups for X11 override redirect windows anymore. We need to be using a regular xdg toplevel as we can't control when these windows are closed.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c1d3b505d915677594d663b9a968d503c2ed6d

commit c6c1d3b505d915677594d663b9a968d503c2ed6d
Author: David Reveman <reveman@chromium.org>
Date: Thu Jun 28 19:50:13 2018

exo: Fix activatable state for transient children

Transient child should not be activatable unless it has an
application id. This allows aura shell clients to create
popup style windows without using the xdg popup API that
requires the ability to dismiss a surface.

Bug:  857465 
Test: exo_unittest --gtest_filter=ShellSurface.SetParent
Change-Id: I628e51af113ab7e3cd73925b9af7e339ef1442cd
Reviewed-on: https://chromium-review.googlesource.com/1118855
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571232}
[modify] https://crrev.com/c6c1d3b505d915677594d663b9a968d503c2ed6d/components/exo/shell_surface_base.cc
[modify] https://crrev.com/c6c1d3b505d915677594d663b9a968d503c2ed6d/components/exo/shell_surface_unittest.cc

Comment 2 by reve...@chromium.org, Jun 28 2018

Owner: reve...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/5b257df9fe6d421d58712f9c9b57a9c47a2d0804

commit 5b257df9fe6d421d58712f9c9b57a9c47a2d0804
Author: David Reveman <reveman@chromium.org>
Date: Fri Jun 29 08:09:05 2018

vm_tools: sommelier: fix X11 override redirect window support

We can't use xdg popups for these windows as we don't control
how they are dismissed.

Using toplevel and aura_shell's set_parent request fix placement
and restores the shadow.

BUG= chromium:857465 
TEST='sommelier -X gtk-demo'

Change-Id: I58e0f7b1ced5e4b65c47ad2ebea96f66294f3830
Reviewed-on: https://chromium-review.googlesource.com/1117915
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Reveman <reveman@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/5b257df9fe6d421d58712f9c9b57a9c47a2d0804/vm_tools/sommelier/sommelier.c

Comment 4 by reve...@chromium.org, Jul 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment