New issue
Advanced search Search tips

Issue 857456 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Regression : Separator line/space/email id text should be in light color is not seen for User name and User email Id at Uber Tray

Project Member Reported by mmanchala@chromium.org, Jun 28 2018

Issue description

Chrome Version: 69.0.3474.0/10824.0.0 dev channel  Kip, Daisy & Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Now click on Uber Tray -> Hover mouse pointer on Profile picture at L.H.S and observe there is no separator line/space/email id text should be in light color between User name and User email Id
(Please refer Video)

Expected: Separator line/space/email id text should be in light color should be seen between User name and User email Id 
Actual: Instead Separator line/space is seen missing and it is seen as email id name

This is Regression Issue as same is working fine in 69.0.3457.0/10784.0.0 dev-channel Daisy

@tetsui : Please confirm the issue

 
Actual_NoSpace.jpg
847 KB View Download
Expected_Space.jpg
905 KB View Download

Comment 1 by tetsui@chromium.org, Jun 29 2018

Status: WontFix (was: Assigned)
This is WAI
Status: Assigned (was: WontFix)
C#1>

Unable to differentiate User Name and User Id on hovering mouse pointer on Profile picture, atleast
a)User Id should be in braces (or)
b)semicolon should be seen between User Name and User Id (or)
c)User Id should be seen in separate line (or)
d)User Id or User Name should be in faded text

Reopening issue for confirmation.

Thanks..!!
Expected_Tooltip.PNG
380 KB View Download
Cc: -ajha@chromium.org sgabr...@chromium.org
Labels: -Pri-1 -Type-Bug-Regression -M-69 M-70 Pri-3 Type-Bug
I think string is already frozen, so it can only be improved in M70. Also the effect of this to the usability is limited. I think UnifiedSystemTray has some tooltip strings that can be improved.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e512c651c9c361f1c8dee74008f5399f2384af30

commit e512c651c9c361f1c8dee74008f5399f2384af30
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Aug 09 02:12:13 2018

Improve profile picture a11y string.

According to QA, when concatenating user name and email, we should put
email in parentheses.

TEST=manual
BUG= 857456 

Change-Id: I8d28ea21dc6c76fb3079d099741019f9285e079e
Reviewed-on: https://chromium-review.googlesource.com/1166758
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581762}
[modify] https://crrev.com/e512c651c9c361f1c8dee74008f5399f2384af30/ash/ash_strings.grd

Status: Fixed (was: Assigned)

Sign in to add a comment