New issue
Advanced search Search tips

Issue 857452 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chromad: Make streamline fields not editable

Project Member Reported by rsorokin@chromium.org, Jun 28 2018

Issue description

If the field is set in the config, it should be disabled to modify
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1092bd9f91699bcdae043231d50079a01047ead

commit e1092bd9f91699bcdae043231d50079a01047ead
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Fri Jul 13 11:21:14 2018

Chromad: Make inputs set from configuration disabled.

Fields set in the streamline configuration should not be modifable by
user.

BUG= chromium:857452 
TEST=manual, I'm going to add tests checking this into CL:1131497

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2835df9dd6b0bd68660302c634747fa216a53b8b
Reviewed-on: https://chromium-review.googlesource.com/1134782
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574881}
[modify] https://crrev.com/e1092bd9f91699bcdae043231d50079a01047ead/chrome/browser/resources/chromeos/login/offline_ad_login.js

Description: Show this description
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified fixed, fields in the streamline configuration are not editable by user (see attached screenshots).

Chrome OS: 10888.0.0
Chrome: 69.0.3494.0
Device: Santa
Screenshot 2018-07-19 at 12.44.22 PM.png
49.9 KB View Download
Screenshot 2018-07-19 at 12.44.38 PM.png
55.2 KB View Download

Sign in to add a comment