New issue
Advanced search Search tips

Issue 857443 link

Starred by 1 user
Status: Fixed
Owner:
alemate@chromium.org
Closed: Jul 20
Cc:
ajha@chromium.org
r...@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regresssion: Spacing is not proper between the buttons in power wash overlay

Project Member Reported by kebalaji@chromium.org, Jun 28 2018 
Chrome Version: 69.0.3474.0/10824.0.0 dev channel Kip,Daisy,Reks
OS: Chrome OS

What steps will reproduce the problem?
(1)In sign-out screen>> Hit Ctrl+Alt+Shift+Reload for Power wash & Restart and observe

Actual: Very less spacing is seen between the 'Restart' and 'Cancel' & 'Power wash' and Cancel buttons
Expected: Proper spacing should be there in between buttons

This is a Regression issue as same is working fine in 69.0.3464.0/10806.0.0 dev

Note : Issue is not seen in Linux,Windows OS

Attached the screencast for reference..
ActualRestartbutton.jpg
1.9 MB View Download
ExpectedRestart.jpg
1.4 MB View Download
ExpectedPowerwashbuttons.jpg
2.4 MB View Download

Comment 1 by jdufault@chromium.org, Jun 28 2018

Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jdufault@chromium.org, Jun 28 2018

Cc: r...@chromium.org
Components: -UI>SignIn UI>Shell>StartScreen
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d

commit c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 20 01:00:16 2018

Chrome OS OOBE: Fix button styling.

This Cl makes buttons correctly spaced on Welcome screen and Powerwash screen.
Assistant opt-in screen now uses cros-shared button style.

Bug:  857443 , 852034 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia90416579b6fefa409ccb4eba7eafeb019136409
Reviewed-on: https://chromium-review.googlesource.com/1142894
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576733}
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/assistant_optin/assistant_optin.html
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_dialog.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_reset.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_reset.html
[delete] https://crrev.com/5c87a0a4aaa5076c66a51b6010a8d1d87573848a/chrome/browser/resources/chromeos/login/oobe_text_button.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_text_buttons.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
[modify] https://crrev.com/c567bddd9b4754b9dd3b04f7f0ee9d7c4d8d485d/chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css

Comment 4 by alemate@chromium.org, Jul 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment