Regression : Unable to re-download video using 'Retry' button on chrome://downloads page.
Reported by
avsha...@etouch.net,
Jun 28 2018
|
||||
Issue descriptionChrome Version : 69.0.3475.0 (Official Build) 95ab095d962f25bee2255b45bc08707b683c821c-refs/branch-heads/3475@{#1} 32/64 bit OS : Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6), Linux(14.04 LTS) Test URL : https://storage.googleapis.com/dalecurtis-shared/buck2.mp4 What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click on 3 dot menu in video and click on 'Download' option. 3. Click on 'Show all' button present at the download shelf (user navigates to chrome://downloads page) and click on 'Cancel' button to stop downloading. 4. Now click on 'Retry' button and observe. Actual Result : Unable to re-download video using 'Retry' button, instead video gets autoplayed. Expected Result : Chrome should re-download the video after clicking on 'Retry' button. This is a regression issue broken in ‘M-68’ and below is the bisect info : Good Build : 68.0.3423.0 (Revision : 556365) Bad Build : 68.0.3424.0 (Revision : 556637) You are probably looking for a change made after 556454 (known good), but no later than 556455 (first known bad). Change Log URL : https://chromium.googlesource.com/chromium/src/+log/72aef1a4cea800fff0d5375c284c6d071cf3d46c..7678c8ace3a3a31cb49225afd9200b72fe22b7aa Suspect : https://chromium.googlesource.com/chromium/src/+/7678c8ace3a3a31cb49225afd9200b72fe22b7aa Jochen@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Able to reproduce issue on Beta build #68.0.3440.42 Thank You..!
,
Jun 29 2018
will not ask for merge...
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d22828ffdeff2b3abf2452bd2fa863a168259e commit 65d22828ffdeff2b3abf2452bd2fa863a168259e Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Jul 03 14:34:15 2018 Use internal API to start downloads from download page Otherwise, the renderer will turn cross-origin downloads into navigations BUG= 857441 R=asanka@chromium.org Change-Id: I7a584951d794d22a6c417d06bd80d6de0db53236 Reviewed-on: https://chromium-review.googlesource.com/1120818 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572205} [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/chrome/browser/resources/md_downloads/browser_proxy.js [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/extensions/browser/api/web_request/web_request_permissions.cc [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/65d22828ffdeff2b3abf2452bd2fa863a168259e/tools/traffic_annotation/summary/annotations.xml
,
Jul 3
,
Jul 4
Update : Tested above in latest Canary build #69.0.3481.0 on Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) & Linux(14.04 LTS) OS and the issue is fixed. Now, user can re-download video using 'Retry' button on chrome://downloads page. kindly review an attached screen-cast for reference. Thank you..! |
||||
►
Sign in to add a comment |
||||
Comment 1 by rbasuvula@chromium.org
, Jun 28 2018Labels: ReleaseBlock-Stable