Small tab strip polish |
||||||
Issue description- Move tab 'x' over a pinch (4pts). - Move new tab 'plus' over a pinch (5pts)
,
Jun 28 2018
Is this iOS-specific? I'm trying to make sure this doesn't have to do with the desktop MD refresh tabstrip work.
,
Jun 29 2018
Sorry, I missed the OS flag. This is iOS specific.
,
Jul 16
,
Jul 16
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91b583c709142e0a322a78a6edfb9b21338c9a25 commit 91b583c709142e0a322a78a6edfb9b21338c9a25 Author: Justin Cohen <justincohen@google.com> Date: Tue Jul 17 16:11:26 2018 [ios] Tab strip UI polish. Bug: 857431 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1c8ae739deab88470f40e5b3c2e241406ecb233e Reviewed-on: https://chromium-review.googlesource.com/1138797 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575661} [modify] https://crrev.com/91b583c709142e0a322a78a6edfb9b21338c9a25/ios/chrome/browser/ui/tabs/tab_strip_controller.mm [modify] https://crrev.com/91b583c709142e0a322a78a6edfb9b21338c9a25/ios/chrome/browser/ui/tabs/tab_view.mm
,
Jul 17
,
Jul 24
Not visually verifiable But X and + icons are looking good. Verified on M70.0.3501.0 canary iOS: 11.4.1, iPad Pro. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by justincohen@chromium.org
, Jun 28 2018Labels: M-69