can't get a webview from Activity anymore
Reported by
mr3...@gmail.com,
Jun 28 2018
|
||||||||||||||||||||||||||
Issue description
THIS TEMPLATE IS FOR FILING BUGS ON THE ANDROID SYSTEM WEBVIEW. GENERAL WEB
BUGS SHOULD BE FILED USING A DIFFERENT TEMPLATE!
Device name:Galaxy S8 and etc.
Android version:8.x, 7.x, 6.x
WebView version (from system settings -> Apps -> Android System WebView):68.0.3440.33
Application:The app is single app contained a webview.
Application version:
URLs (if applicable):
Steps to reproduce:
(1)) I execute the app.
(2)
(3)
Expected result:
I see the webview in the app.
Actual result:
the app crushed.
Comments:
I'm in charge of app development. The app contained a single webview.
I used the android system webview beta (version 68) today and I found a critical issue.
I used to dynamically find webview at activity. but the code isn't work anymore.
1. View tempView = this.getWindow (). GetDecorView (). GetRootView ();
ArrayList <View> list = tempView.getTouchables ();
2. View temp2View = this.findViewById (R.id.webview);
I tested above two type of code at the resume event (activity), but there is a problem in the beta webview.
I wont be able to use the way to get webview from acitivity in the new webview anymore? Let me know whether this is a just error of new version or improvement things.
*for this test, I changed disable state a crome app.then I installed a android webview beta.
,
Jun 29 2018
Thanks for reporting this issue. Could you please share any sample application on which the issue is reproduced. This would help us in reproducing the issue and triaging the issue further. Also, please share the screen cast for better understanding. Thanks!
,
Jul 3
I can't upload a sample project cause my company's security policy. Would I send a sample project using e-mail? (to pnangunoori@chromium.org)
,
Jul 3
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 3
I sent a sample source using e-mail to pnangunoori, jbanavatu and sheriffbot I couldn't send a full source cause your security issue. Thanks!
,
Jul 4
Are you able to provide us with logcat output? And are you able to provide a link to the sample project? Emailing it directly to individuals isn't as useful as making it generally available.
,
Jul 5
Hello. I attached a sample project. If you run the app in android system webview beta version, you can see a "failed test" toast. But if you run the app in android system webview prd version, you can see a "passed test" toast. please check the function named "getWebView". We used the apis for long time. I wont be able to use the way to get webview from acitivity in the new webview anymore? Let me know whether this is a just error of new version or improvement things. Thank you.
,
Jul 5
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 5
so the behaviour change is that getTouchables no longer returns the WebView instance. That may - or may not - be a bug, but either way you don't need it, because temp2View is the WebView, and could be cast as such.
,
Jul 5
,
Jul 5
Between 67.0.3396.0 and 68.0.3399.0, we regressed the clickable state of the WebView.
,
Jul 5
,
Jul 6
Hello. It's just sample. Our apps made by the special webview which is protected by solution company. So we have to use that function. Do you have a plan to fix at release version?
,
Jul 6
This is a bug and will be fixed before version 68 is stable.
,
Jul 6
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone. All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
,
Jul 9
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26f4a8ec510212912e3df32c834f806b495db66d commit 26f4a8ec510212912e3df32c834f806b495db66d Author: Laís Minchillo <laisminchillo@chromium.org> Date: Mon Jul 23 10:39:56 2018 Ensure webview is clickable Originally the webview content was always set to clickable but after http://crrev.com/551479 it wasn't. This CL restores original behaviour. Also adds a test to ensure this remains true in the future. Bug: 857427 Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e Reviewed-on: https://chromium-review.googlesource.com/1127951 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577138} [modify] https://crrev.com/26f4a8ec510212912e3df32c834f806b495db66d/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [add] https://crrev.com/26f4a8ec510212912e3df32c834f806b495db66d/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsContainerViewTest.java [modify] https://crrev.com/26f4a8ec510212912e3df32c834f806b495db66d/android_webview/test/BUILD.gn
,
Jul 23
,
Jul 23
,
Jul 24
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/005814e294c3015e52be6f2d8a26658df6397c36 commit 005814e294c3015e52be6f2d8a26658df6397c36 Author: Tobias Sargeant <tobiasjs@google.com> Date: Tue Jul 24 12:39:32 2018 Ensure webview is clickable Originally the webview content was always set to clickable but after http://crrev.com/551479 it wasn't. This CL restores original behaviour. Also adds a test to ensure this remains true in the future. TBR=laisminchillo@chromium.org (cherry picked from commit 26f4a8ec510212912e3df32c834f806b495db66d) Bug: 857427 Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e Reviewed-on: https://chromium-review.googlesource.com/1127951 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577138} Reviewed-on: https://chromium-review.googlesource.com/1148383 Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#35} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/005814e294c3015e52be6f2d8a26658df6397c36/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [add] https://crrev.com/005814e294c3015e52be6f2d8a26658df6397c36/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsContainerViewTest.java [modify] https://crrev.com/005814e294c3015e52be6f2d8a26658df6397c36/android_webview/test/BUILD.gn
,
Jul 24
@pnangunoori: Please check if the issue can be verifiable with the provided as per comment#5 on latest 69
,
Jul 26
Hello. I got a reports from my customer after updating to 68. (chrome, released by 18.7.24) They can't use our apps. I got a comment#14, then didn't check anymore. Please, give me a solution. (or, please stop release before solve this issue)
,
Jul 26
If you want to know my conditions. please run to my sample project (comment #7)
,
Jul 26
@mr3409: As per comment#24 we are unable to verify this issue without .apk file, providing .apk file would be very helpful in verifying this issue from TE end. And as per comment#18 this issue seems to be fixed in latest canary. Could you please download latest canary from play store, and after enabliong developer options >> navigate to Device Settings >> Webview Implementation and select canary to use webview of canary build. Please check above steps and help in verifying the fix from your end. Thanks!
,
Jul 26
,
Jul 26
How should this bug be assigned to?
,
Jul 26
All good!
,
Jul 26
,
Jul 26
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
,
Jul 27
comment#27, comment#18 I have checked as per comment. and I have confirmed the issue is fixed below versions. chrome DEV version (69.XXX) chrome canary version (70.XXX) but My customer can't use our service. I'm receiving too many VOCs from customers. Please let me know your plan, when you will release fixed version.
,
Jul 27
We are going to release a new version of M68 stable next Monday 7/30. The fix for this issue will be included as it is getting merged today.
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31b5c1059713d5cef51ee898e9b37268262b67d9 commit 31b5c1059713d5cef51ee898e9b37268262b67d9 Author: Laís Minchillo <laisminchillo@chromium.org> Date: Fri Jul 27 15:46:59 2018 Ensure webview is clickable Originally the webview content was always set to clickable but after http://crrev.com/551479 it wasn't. This CL restores original behaviour. Also adds a test to ensure this remains true in the future. Bug: 857427 Change-Id: If7a765f146290b933f57e514f26ad8a672f7695e Reviewed-on: https://chromium-review.googlesource.com/1127951 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577138}(cherry picked from commit 26f4a8ec510212912e3df32c834f806b495db66d) Reviewed-on: https://chromium-review.googlesource.com/1153147 Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#758} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/31b5c1059713d5cef51ee898e9b37268262b67d9/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [add] https://crrev.com/31b5c1059713d5cef51ee898e9b37268262b67d9/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsContainerViewTest.java [modify] https://crrev.com/31b5c1059713d5cef51ee898e9b37268262b67d9/android_webview/test/BUILD.gn
,
Jul 30
Verified on Pixel XL/OPM1.180608.001 with launching apk results " Pass test" on latest 68 build . +mr409@gmail.com: Please verify the issue once build available and mark the issue verified .
,
Jul 31
Hello. @#37 Do you want me to verify the issue? How do I get a chrome apk which is latest 68 build? If you have got a "Pass test" from apk of #7, It means that the issue has been fixed. I already have tested as below 1. Chrome Canary 70.0.3507.0 (Passed) 2. Chrome Dev 69.0.3497.9 (Passed) 3. Chrome Beta 68.0.3440.70 (Failed) 4. Chrome 68.0.3440.70 (Failed) If you want to check using another chrome version, please let me know, How could I get it. Thanks a lot.
,
Jul 31
Sounds like this is verified (this change is not in the version of M68 you've tested). Thanks, mr3409@!
,
Aug 1
Hello, #39, Thanks!! and According to #30, I have thought the stable version that have fixed this issue will be to the public on July 30th. Our team is waiting for this issue to be addressed. Please, let me know your plan when do you release fixed version (stable) Thanks a lot.
,
Aug 1
We distribute releases incrementally. We have not yet released M68 to 100% of users. In Comment 35, cmasso@ means that we will continue our release process, not that we will reach 100% by July 30th. Thank you for your patience.
,
Aug 1
Thank you for your explanation. I have additional questions, please explain more. 1. The M68 version currently being released is fixed version. right? not 68 version (68.0.3440.70) 2. Our customers who have already had problems do not need another guide? Is M68 installed automatically for customers? - They have already installed the the 68 version(68.0.3440.70) - They are using the automatic installation feature of the Play store. Thanks!
,
Aug 1
1. Right. "respin" (in comment 35) means pushing a new version. 2. I recommend your users switch to WebView stable (this is the default, as opposed to beta/dev/canary). Your users will indeed update automatically.
,
Aug 2
Among my customers and our team members, starting update to new chrome (68.0.3440.85) And We have checked the issue is vanished. Thank you for everything you've done.
,
Aug 28
Hello, We have received reports from our partners that this is no longer working in Chrome 69 Beta. There may have been a regression. Can you please take a look?
,
Aug 29
,
Aug 29
Is this a new regression?
,
Aug 29
The sample project attached to this bug works for me on 69.0.3497.53 which is the current beta version. Maybe they're having a different problem?
,
Aug 30
Removing release block stable from this as until we get a clearer idea of what is going on, as the regression isn't reproducible.
,
Oct 12
|
||||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||||
Comment 1 by pnangunoori@chromium.org
, Jun 29 2018