New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 857424 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted focus highlight is seen on 'Passphrase' text field of chrome://settings/syncSetup.

Reported by db...@etouch.net, Jun 28 2018

Issue description

Chrome Version: 69.0.3475.0 Revision 95ab095d962f25bee2255b45bc08707b683c821c-refs/branch-heads/3475@{#1}(32/64 bit)
OS: Win (7,8,8.1,10), Mac OS X (10.12.6,10.13.1,10.13.6), Linux (14.04 LTS).

Pre-condition: Sign in into browser with valid credentials which has Passphrase.

What steps will reproduce the problem?
(1) Launch chrome, Navigate to chrome://settings/syncSetup and click on Passphrase text field.
(2) Now click on omnibox and observe Passphrase text field.

Actual: Unwanted focus highlight is seen on Passphrase text field even if focus shifted to omnibox.

Expected: Focus highlight should not seen on Passphrase text field after focus shifted to omnibox.

This is a regression issue, broken in 'M69', below is bisect info:

You are probably looking for a change made after 564676 (known good), but no later than 564677 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/3ec8c0556c4b6af90db14c365ee0376c72982905..66c801f15e20c5a8399054d7f8d8fc53477c6302

Suspect: https://chromium.googlesource.com/chromium/src/+/66c801f15e20c5a8399054d7f8d8fc53477c6302

@scottchen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.




 
Actual_Focus.mov
3.1 MB View Download
Expected_Focus.mov
2.1 MB View Download

Comment 1 by db...@etouch.net, Jun 28 2018

Note: Manual bisect range is as below:

Good Build:69.0.3450.0(Revision: 564324)
Bad Build: 69.0.3451.0(Revision: 564768)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c6f06a99ec2ede6a9bac286c1cd2ff6f49bf0b

commit f4c6f06a99ec2ede6a9bac286c1cd2ff6f49bf0b
Author: Scott Chen <scottchen@chromium.org>
Date: Sat Jun 30 01:31:43 2018

WebUI[MD-refresh]: replace paper-input in media-router

Bug:  857424 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I205f279363b21324cc89d7c0ab44bd042beab588
Reviewed-on: https://chromium-review.googlesource.com/1121107
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571734}
[modify] https://crrev.com/f4c6f06a99ec2ede6a9bac286c1cd2ff6f49bf0b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/f4c6f06a99ec2ede6a9bac286c1cd2ff6f49bf0b/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42d1c8517086c18a80a99acc8638e86a7f43c3b

commit f42d1c8517086c18a80a99acc8638e86a7f43c3b
Author: Scott Chen <scottchen@chromium.org>
Date: Mon Jul 02 19:38:59 2018

WebUI: set focus more correctly for cr-input.

Detect focus or blur in a more straight-forward way.

Bug:  857424 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5be06c7cdbdbaedf20a1c6bc9198bcc539c1be32
Reviewed-on: https://chromium-review.googlesource.com/1119160
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571969}
[modify] https://crrev.com/f42d1c8517086c18a80a99acc8638e86a7f43c3b/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/f42d1c8517086c18a80a99acc8638e86a7f43c3b/ui/webui/resources/cr_elements/cr_input/cr_input.js

Sign in to add a comment