New issue
Advanced search Search tips

Issue 857388 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Pepper Flash Font File Host may instantiate fonts of wrong font weight

Project Member Reported by drott@chromium.org, Jun 28 2018

Issue description

The existing code in https://cs.chromium.org/chromium/src/chrome/renderer/pepper/pepper_flash_font_file_host.cc?l=24 looks like it may instantiate an incorrect font weight.

Spun off from review in 
https://chromium-review.googlesource.com/c/chromium/src/+/1109964/16/chrome/renderer/pepper/pepper_flash_font_file_host.cc#b34

thestig@ explains that there is probably missing conversion between  PP_BROWSERFONT_TRUSTED_WEIGHT_* and SkFontStyle enum Weight. 

"PP_BROWSERFONT_TRUSTED_WEIGHT_100, and 1 is PP_BROWSERFONT_TRUSTED_WEIGHT_200, etc. But SkFontStyle uses 0 for kInvisible_Weight and 100 for kThin_Weight, etc."


 

Sign in to add a comment