New issue
Advanced search Search tips

Issue 857386 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Bad selector formatting in git cl format in Objective C

Project Member Reported by olivierrobin@chromium.org, Jun 28 2018

Issue description

Result of git cl format

void FormActivityObserverBridge::DidSubmitDocument(web::WebState* web_state,
                                                   const std::string& form_name,
                                                   bool has_user_gesture,
                                                   bool source_frame_is_main) {
  DCHECK_EQ(web_state, web_state_);
  if ([owner_ respondsToSelector:@selector
              (webState:submittedDocumentWithFormNamed:hasUserGesture
                          :sourceFrameIsMain:)]) {
    [owner_ webState:web_state
        submittedDocumentWithFormNamed:form_name
                        hasUserGesture:has_user_gesture
                     sourceFrameIsMain:source_frame_is_main];
  }
}

Note that the selector in the if is quite bad (: on new line).
 
Status: Available (was: Untriaged)

Sign in to add a comment