New issue
Advanced search Search tips

Issue 857380 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
jdonnelly@chromium.org
nyerramilli@chromium.org
kylixrd@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:No difference is observed in vertical margin of omnibox for 4,6,8,10,12,14 px.

Reported by shruti.j...@etouch.net, Jun 28 2018 
Chrome Version: 69.0.3475.0 (Official Build) (64-bit) (cohort: Stable)Revision	95ab095d962f25bee2255b45bc08707b683c821c-refs/branch-heads/3475@{#1}(64-bit)

OS: Windows(7,8,8.1,10)

Pre-condition:Enable 'Omnibox UI Vertical Margin(Enable 4px vertical margin and 14 px vertical margin)'

Steps to reproduce:
1.Launch chrome, Enable 4px vertical margin and 14 px vertical margin from chrome://flags simultaneously.
2.Observe vertical margin in omnibox respectively for 4px vertical margin and 14 px vertical.

Actual:No difference is observed in vertical margin of omnibox for 4,6,8,10,12,14 px.
Expected:Vertical Margin difference should be observed in omnibox for 4,6,8,10,12,14 px.

This is regression issue broken in ‘M-69’ and manual bisect info:
Good Build:69.0.3472.0
Bad Build:69.0.3473.0

Unable to provide bisect using per-revision script,Hence providing bisect with old script: 
Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/3c16d9d466102e0839cad4e70cea850107143ca4..64c540a750df6adb453c0f8e6e63800d8948d04c

Suspect:https://chromium.googlesource.com/chromium/src/+/8a4187003e401bcb6a541427fe72fc425c5a9f1b

@Allen Bauer : Could you please help to reassign if your change is not the cause for this change. 
Note:Set Any 4,6,8,10,12,14 px and observe the results in vertical margin.

Kindly refer the attached video.

Thank You!
Expected_Result.mp4
729 KB View Download
Actual_Result.mp4
735 KB View Download
Actual14px.png
12.1 KB View Download
Actual4px.png
10.8 KB View Download
Expected4px.png
8.1 KB View Download
Expected14px.png
9.5 KB View Download

Comment 1 by kylixrd@chromium.org, Jun 28 2018

Cc: kylixrd@chromium.org
Owner: jdonnelly@chromium.org
jdonnelly@ Please reassign as necessary.

Comment 2 by mpear...@chromium.org, Jun 28 2018

Cc: jdonnelly@chromium.org
Owner: ----
Status: WontFix (was: Assigned)
WontFix because the material design mode that was just enabled by default overides these flags.

We'll remove the flag naturally during the cleanup after material design definitively launches.  (jdonnelly@, feel free to file a bug if you feel you need a reminder to clean up this particular about:flag.  I'm just assuming that the cleanup audit will catch everything.)
►

Sign in to add a comment