New issue
Advanced search Search tips

Issue 857370 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Jul 5
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Default focus doesn't seen on 'Search history' text-box on History page.

Reported by dchau...@etouch.net, Jun 28 2018 
Chrome Version: 69.0.3475.0 (Official Build) Revision 95ab095d962f25bee2255b45bc08707b683c821c-refs/branch-heads/3475@{#1} 32/64-bit.
OS: Win (7,8,8.1,10), Mac OS X (10.12.6,10.13.1,10.13.6), Linux (14.04 LTS).

What steps will reproduce the problem?
1. Launch Chrome, navigate to chrome://history page and observe.

Actual: Default focus doesn't seen on 'Search history' text-box.
Expected: Default focus doesn't seen on 'Search history' text-box.

This is a regression issue, broken in M-69 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Jun 28 2018

Labels: hasbisect-per-revision OS-Linux OS-Mac OS-Windows
Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range:

Good build: 69.0.3457.0 (Revision: 566679) 
Bad build: 69.0.3460.0 (Revision: 567312)

Using the per-revision bisect providing the bisect results:

You are probably looking for a change made after 566762 (known good), but no later than 566763 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/75899c507d925ffe0fa66d8ad73776e66d6339ac..31414f90a35d99834cbe2c96a95a9abb7012448d

Suspecting: https://chromium.googlesource.com/chromium/src/+/31414f90a35d99834cbe2c96a95a9abb7012448d

@calamity: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
265 KB View Download
Expected behavior.mp4
279 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2b86361cda608e5b8b37ba2a78011cfa13a618

commit cb2b86361cda608e5b8b37ba2a78011cfa13a618
Author: Christopher Lam <calamity@chromium.org>
Date: Wed Jul 04 09:20:41 2018

[MD History] Focus search field on load.

This CL fixes an issue where the search field was not focused on load
after a CSS change. This seemed to happen because the transition caused
a frame of 'visibility: hidden' to race with the toolbar focus() call.

Bug:  857370 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id4ac3b15e1f1a886b6fb1c3af4512a878fb87150
Reviewed-on: https://chromium-review.googlesource.com/1122027
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572522}
[modify] https://crrev.com/cb2b86361cda608e5b8b37ba2a78011cfa13a618/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html

Comment 3 by calamity@chromium.org, Jul 5

Status: Fixed (was: Assigned)

Comment 4 by pranjali...@etouch.net, Jul 5

Labels: TE-Verified-M69 TE-Verified-69.0.3482.0
Update:

Rechecked the above issue on Win (7,8,8.1,10), Mac OS X (10.12.6,10.13.1,10.13.6), Linux (14.04 LTS) using latest canary #69.0.3482.0 and issue is fixed.Default focus is seen on 'Search history' text box on history page.

please refer below attached screen cast for reference.

Thank You.
Canary_behaviour.mp4
210 KB View Download
►

Sign in to add a comment