New issue
Advanced search Search tips

Issue 857366 link

Starred by 2 users
Status: Assigned
Owner:
bettes@chromium.org
Cc:
lpalmaro@chromium.org
jdonnelly@chromium.org
nyerramilli@chromium.org
kylixrd@chromium.org
rbasuvula@chromium.org
bklmn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus doesn't appear clearly in incognito while traversing through block icon in omnibox after hitting 'tab' key

Reported by vku...@etouch.net, Jun 28 2018 
Chrome Version:69.0.3475.0 (Official Build)Revision 95ab095d962f25bee2255b45bc08707b683c821c-refs/branch-heads/3475@{#1}(32/64-bit) 
OS: Windows(7,8,8.1,10) & Linux(14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and navigate to https://permission.site/ > click on HTTPS
(2)Click on any 3 button for e.g Microphone,location & auto download such that bubble appears > click block 
(3)Now press 'F6' key from keyboard, hit 'tab' key such that focus traverse through blocked icon in omnibox

Actual: Focus doesn't appear clearly while traversing through block icon in omnibox after hitting 'tab' key

Expected: Focus should appear properly while traversing through block icon in omnibox after hitting 'tab' key 

This is a regression issue broken in 'M69' and below is the manual regression range
Good Build: 69.0.3472.3(Revision:569949)
Bad Build:  69.0.3473.0(Revision:570288)

Note: Issue not seen on  Mac OS(10.12.6, 10.13.1, 10.13.5, 10.13.6)
Actual_Incognito.mp4
343 KB View Download
Expected_Incognito.mp4
226 KB View Download

Comment 1 by vku...@etouch.net, Jun 28 2018

Labels: RegressedIn-69 FoundIn-69 Target-69 hasbisect
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)
Narrow bisect URL:
You are probably looking for a change made after 570216 (known good), but no later than 570235 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/3c16d9d466102e0839cad4e70cea850107143ca4..64c540a750df6adb453c0f8e6e63800d8948d04c

Suspecting: r570226 ?

@kylixrd: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by mpear...@chromium.org, Jun 28 2018

Cc: bklmn@chromium.org
Components: -UI>Browser>Omnibox UI>Browser>Permissions>Indicators
Summary: Regression:Focus doesn't appear clearly in incognito while traversing through block icon in omnibox after hitting 'tab' key (was: Regression:Focus doesn't appear clearly while traversing through block icon in omnibox after hitting 'tab' key)
Moving into permission indicator bug queue.

vkupte@: is the complaint that "focus doesn't appear clearly" more about the color contrast (background to foreground) or the fact that the highlight changes from something more like a square to a rectangle?

Most likely these changes are to spec, but I leave it to someone else to confirm (bklmn@?).

Comment 3 by vku...@etouch.net, Jun 29 2018 

With respect to comment #2:

Yes the complaint is that "focus doesn't appear clearly" more about the color contrast in Incognito window.

Comment 4 by mpear...@chromium.org, Jun 29 2018

Cc: kylixrd@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Thanks for the clarification.  Marking as untriaged so it's more likely to be picked up by appropriate people, including bklmn@.

Comment 5 by skare@google.com, Jul 3 

+1 to mpearson's triage.
also note omnibox is rounded in new screen, so studies -may- have changed as well.

Comment 6 by dominickn@chromium.org, Jul 16

Cc: lpalmaro@chromium.org jdonnelly@chromium.org
Components: -UI>Browser>Permissions>Indicators
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
+bettes, +jdonnelley, +lpalmaro

I assume this is part of the MD2 refresh. bettes, are you/bklmn@ the right person to confirm the spec for this?

Also, +lpalmaro, is this focus sufficient for accessibility? It does look quite dim to me.

Comment 7 by rp...@etouch.net, Nov 14

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
"Mass UI Triage" update :
Rechecked the above issue on Windows(7,8,8.1,10) & Linux(14.04 LTS) using latest Canary build : 72.0.3610.0 and the issue is still reproducible.

@bettes: Could you please take a look in to this issue.

Thank you..!!
Canary_Behaviour.mp4
512 KB View Download
►

Sign in to add a comment