New issue
Advanced search Search tips

Issue 857345 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Icing-related level DB might grow too big

Project Member Reported by wychen@chromium.org, Jun 28 2018

Issue description

There are two level DBs for Icing: delta file and usage report buffer. If Icing doesn't consume these data feeds successfully, these databases could grow indefinitely. It would be safer if we add some metrics to see how it behaves in the wild.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07b372543428b617d9076b9954b768acf5ae32ef

commit 07b372543428b617d9076b9954b768acf5ae32ef
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 10 00:40:59 2018

Add UMA for history report

Add the following UMA metrics:
- Search.HistoryReport.DeltaFile.LastSeqNo
- Search.HistoryReport.DeltaFile.LevelDBEntries
- Search.HistoryReport.UsageReportsBuffer.LevelDBEntries

These are health checking signals to see if Icing-related levelDBs
could grow too big.

Bug: 857345
Change-Id: Icfc67b3442864a1c31b15427de40b406ea674ff7
Reviewed-on: https://chromium-review.googlesource.com/1117937
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573559}
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/chrome/browser/android/history_report/delta_file_backend_leveldb.cc
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/chrome/browser/android/history_report/delta_file_service.h
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/chrome/browser/android/history_report/usage_report_util.cc
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/chrome/browser/android/history_report/usage_report_util.h
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/chrome/browser/android/history_report/usage_reports_buffer_backend.cc
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/chrome/browser/android/proto/delta_file.proto
[modify] https://crrev.com/07b372543428b617d9076b9954b768acf5ae32ef/tools/metrics/histograms/histograms.xml

Sign in to add a comment