Investigate "notifyEntriesCahnged" invalidating cache. |
||
Issue descriptionFor "My Files" UI change on crrev.com/c/1113258 the call on MetadataModel.notifyEntriesChanged() was invalidating the metadata cache causing some folders to not have their modificationTime displayed because by the time it tried to display the cache was invalidated. So the following line was removed from SubDirectoryItem.updateSharedStatusIcon() (in directory_tree.js): this.parentTree_.metadataModel.notifyEntriesChanged([this.dirEntry_]); This bug is to track: 1. If this line is really required; 2. Or, a proper fix for this issue.
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ba34c773c0b534460f1cd232f7888a05c078a08 commit 6ba34c773c0b534460f1cd232f7888a05c078a08 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Jul 24 03:26:46 2018 Change directory tree to update all required metadata Re-enables the call to |notifyEntriesChanged| and refresh all required metadata which includes "share", "modificationTime" and "size" among others. The method |notifyEntriesChanged| invalidates all metadata, so we should update all required metadata fields. This fixes the issue where file list (RHS) wouldn't display modification time column, because sometimes when it would try to display the metadata had been invalidated due to the call to |notifyEntriesChanged|. |notifyEntriesChanged|, so the fact that they're all passing now it's the the actual test. Test: Several tests were failing when re-enabling Bug: 857343 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5a1e243c22c4040530c55d3d41708740dd617d88 Reviewed-on: https://chromium-review.googlesource.com/1117966 Reviewed-by: Daichi Hirono <hirono@chromium.org> Reviewed-by: Sasha Morrissey <sashab@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#577418} [modify] https://crrev.com/6ba34c773c0b534460f1cd232f7888a05c078a08/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
,
Jul 24
This is an internal change, but it can be checked/tested by checking the file list/table on the right hand side if it has modifiedTime and size for all folders and files. |
||
►
Sign in to add a comment |
||
Comment 1 by lucmult@chromium.org
, Jul 23