New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857308 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 28 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: expose precise element position on the page that works for inline elements

Project Member Reported by lushnikov@chromium.org, Jun 28 2018 
Downstream bug: https://github.com/GoogleChrome/puppeteer/issues/2798

Currently, there's no good way to know how an inline element is layouted
on the page. For example, check out attached screenshot: there's a link that wraps on multiple lines.

Puppeteer needs a way to click on element. For this to work,
there should be a way to know element exact position on the page so that
we can issue precise mouse events.
2018-06-27.png
23.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7

commit ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Thu Jun 28 20:00:43 2018

DevTools: introduce DOM.getContentQuads protocol method

This patch introduces a new DOM.getContentQuads method.

This method returns content quads for the given node. In case of
inline elements this method might return multiple quads.

BUG= 857308 
R=dgozman

Change-Id: I347d399fd7592295e5ddc8ea1e93b16090423499
Reviewed-on: https://chromium-review.googlesource.com/1117920
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571235}
[add] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getContentQuads-expected.txt
[add] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getContentQuads.js
[add] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/WebKit/LayoutTests/inspector-protocol/dom/resources/inline-wrap.html
[modify] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/blink/renderer/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/blink/renderer/core/inspector/inspector_dom_agent.h
[modify] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/blink/renderer/core/inspector/inspector_highlight.cc
[modify] https://crrev.com/ee1f0d244ef6ef92a918d2f7a7c4da66e21a46d7/third_party/blink/renderer/core/inspector/inspector_highlight.h

Comment 2 by lushnikov@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment