New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 857302 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 870139
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Migrate Tether metrics with new MultiDevice APIs

Project Member Reported by hansberry@chromium.org, Jun 28 2018

Issue description

The MultiDevice APIs replace BleConnectionManager, which tied to several key metrics. See HostConnectionMetricsLogger and BleConnectionMetricsLogger.
 
Labels: -Pri-1 Pri-2
Status: Assigned (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f994f436c5f6994446afcefe21c675814452ae2

commit 9f994f436c5f6994446afcefe21c675814452ae2
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Tue Sep 18 19:37:56 2018

[CrOS Multidevice] Do not initialize BleConnectionManager if MultiDevice APIs are active.

In the process, this also adapts HostConnectionMetricsLogger to use the MultiDevice APIs
to properly log to the "Background" versions of its metrics.

Bug: 824568,  752273 ,  854885 ,  857302 
Change-Id: I77fc52b3d07d903fe61ac62de2620216984d28de
Reviewed-on: https://chromium-review.googlesource.com/1117897
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592146}
[modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/asynchronous_shutdown_object_container_impl.cc
[modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/host_connection_metrics_logger.cc
[modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/host_connection_metrics_logger.h
[modify] https://crrev.com/9f994f436c5f6994446afcefe21c675814452ae2/chromeos/components/tether/host_connection_metrics_logger_unittest.cc

Mergedinto: 870139
Status: Duplicate (was: Assigned)
HostConnectionMetricsLogger has now been migrated.

The metrics from BleConnectionMetricsLogger remain unmigrated. That work is already being tracked in  crbug.com/870139 , so I'm marking this bug as a duplicate of it.

Sign in to add a comment