New issue
Advanced search Search tips

Issue 857298 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Find-in-page broken on patents.google.com when Chrome is set to "continue where you left off" and page is reopened

Reported by dblagent...@gmail.com, Jun 28 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.33 Safari/537.36

Steps to reproduce the problem:
1. Create a new profile.
2. Open the new profile in Chrome.
3. Select "Settings" in the drop down menu accessed by clicking on the three dots in the upper right corner.
4. Change the "On startup" setting to "Continue where you left off." Exit the settings.
5. Enter https://patents.google.com/patent/US9123456B2 in a omnibox and hit enter to load the page.
6. Select "find" in the drop down menu accessed by clicking on the three dots in the upper right corner and search for "20" (without the quotes). It shows there are 161 results.
7. Press the down arrow in the Find box and navigate through the first 15 results. This shows that the Find in page function is working.
8. Scroll back to the top of the page.
9. Close the window by clicking on the "X" in the upper right hand corner.
10. Reopen the profile. This loads the same page on Google patents. 
11. Select "Find" in the drop down menu and enter 20 in the box.
12. Press the down arrow in the Find box 15 times. The down button works to select the next search result until the next result is below the visible page. At that point, when you hit the down button, the find box disappears.

What is the expected behavior?
At step 12, the find box should have remained visible and it should have highlighted the next search result. 

What went wrong?
The find box should have remained visible as the user cycles through the search results.

The attached video shows steps 11 and 12. You can see how the find box disappears.

Did this work before? Yes I don't know. I've noticed this problem for at least a few months (I think).

Chrome version: 68.0.3440.33  Channel: beta
OS Version: 10.0
Flash Version:
 
Screencast.webm
3.9 MB View Download
Labels: Needs-Triage-M68 Needs-Bisect
Components: -UI UI>Browser>FindInPage
Labels: -Needs-Bisect -Type-Bug-Regression Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Mac Type-Bug
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chrome version stable #68.0.3440.33  and on latest chrome #69.0.3474.0 using Linux Ubuntu 17.10,Windows 10 & Mac 10.13.5. 
 
Same behaviour is seen on M60(60.0.3112.0) hence considering it as non-regression and marking it as Untriaged.

Attached screen cast for reference.

Thanks!
857298.mp4
9.7 MB View Download
Cc: rakina@chromium.org
rakina@, I see you're familiar with find-in-page.  Can you triage this issue?  I'm not even sure if should go on the Blink or Chromium side of the code.
Hmm, probably a problem with text selections in Blink? I'm not familiar what stays when "continue where you left off" is done though. It's also kinda weird that the find bar also goes missing, usually problems in renderer side doesn't affect the UI so there might me some weird stuff happening there too.
Components: Blink>Editing>Selection
Guessing the right component is Blink>Editing>Selection, from comment #4.  Please re-triage if I'm wrong.
Components: -UI>Browser>FindInPage -Blink>Editing>Selection UI>Browser>Navigation
Route to "UI>Browser>Navigation", it seems "Continue where you left off" rests find-in-page UI when Chrome attempt to display below Above-the-fold.
See the attached video. I can replicate the issue without "Continue where you left off" coming into play. One thing to note is that I opened the second tab by right clicking on the first tab and selecting "duplicate." My video capture software didn't pick up on that step for some reason.
Screencast.webm
5.9 MB View Download
Looking at the video again, I opened the find in page box by selecting "Find" in the drop down menu accessed by pressing the button with the three dots. It wasn't recorded by my video capture software (I guess it doesn't capture menus in Chrome for some reason). 

Sign in to add a comment