New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 857282 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Revert New Tab Button Finch Experiment

Project Member Reported by robliao@chromium.org, Jun 28 2018

Issue description

Since the New Tab Button will be in the trailing position, the Finch experiment is now redundant.
 
Labels: M-70
Components: UI>Browser>NewTabPage
Cc: -pkasting@chromium.org
Owner: pkasting@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/630979171b981ffefd07c1e31036f322b6cb03f1

commit 630979171b981ffefd07c1e31036f322b6cb03f1
Author: Peter Kasting <pkasting@chromium.org>
Date: Sat Jun 30 02:09:03 2018

Change NTB default position to AFTER_TABS, add flags, remove Finch control.

I'm not opposed to leaving this under Finch control for future experimentation,
but I don't really know how to use FEATURE_WITH_PARAMS_VALUE.

Bug:  857610 ,  857282 ,  855729 
Change-Id: Ibe1b9c13003f2da78b241e775f37b2e9ab7e71f7
Reviewed-on: https://chromium-review.googlesource.com/1119362
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571739}
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/about_flags.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/common/chrome_switches.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/common/chrome_switches.h
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment