Issue metadata
Sign in to add a comment
|
Broken compilation for 69.0.3474.2 |
||||||||||||||||||||
Issue description
Compilation config:
target_os="android"
target_cpu="arm"
enable_nacl=false
symbol_level=0
remove_webcore_debug_symbols=true
is_debug=false
dcheck_always_on=false
is_component_build=false
use_jumbo_build=true
Error:
In file included from gen/chrome/browser/browser_jumbo_2.cc:11:
In file included from ./../../chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc:34:
In file included from ./chrome/browser/io_thread.h:25:
./chrome/browser/net/chrome_network_delegate.h:183:60: error: non-virtual member function marked 'override' hides virtual member function
const net::CookieList& cookie_list) override;
^
../../net/base/network_delegate_impl.h:85:8: note: hidden overloaded virtual function 'net::NetworkDelegateImpl::OnCanGetCookies' declared here: different number of parameters (3 vs 2)
bool OnCanGetCookies(const URLRequest& request,
^
In file included from gen/chrome/browser/browser_jumbo_2.cc:11:
In file included from ./../../chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc:34:
In file included from ./chrome/browser/io_thread.h:25:
./chrome/browser/net/chrome_network_delegate.h:186:52: error: non-virtual member function marked 'override' hides virtual member function
net::CookieOptions* options) override;
^
../../net/base/network_delegate_impl.h:89:8: note: hidden overloaded virtual function 'net::NetworkDelegateImpl::OnCanSetCookie' declared here: different number of parameters (4 vs 3)
bool OnCanSetCookie(const URLRequest& request,
^
2 errors generated.
Actual result:
,
Jun 28 2018
reopening- still exists
,
Jun 29 2018
hi, https://chromium-review.googlesource.com/c/chromium/src/+/1113903 is breaking compilation, please fix.
,
Jun 29 2018
note: it's probably related to Jumbo, please make sure, that you're compiling about 23000 files (not more than 30000)
,
Jun 29 2018
The compile error there looks like it has an old version of the code, for example OnCanGetCookies and OnCanSetCookie now have an extra bool param in chrome_network_delegate.h that isn't shown in the error. Does this error still happen with a fresh checkout?
,
Jun 29 2018
Error message is strange and maybe not 100% accurate (comparable to source), I don't get it when delete patch + everything after.
,
Jun 29 2018
(patch can't be clean reverted on my tree)
,
Jun 29 2018
Are you able to build with use_jumbo_build=false? Also, does chrome/browser/net/chrome_network_delegate.h:183 match what you see in the compile error?
,
Jun 29 2018
Or just try a clean build with a branch that's hard reset to origin/master - that build error really does look like you have an old version of the code.
,
Jun 29 2018
Unfortunately I cannot spend time on it for next days, I know that patch is changing exactly marked place and after removing it build is done. Can I ask you for confirming/rejecting this please? Or investigating it more? I don't have such (especially time) resources now and this can affect many people.
,
Jun 29 2018
Other branch hard reset to origin/master seems to have problem too... up to moment when I will back to last patch before yours.
,
Jun 29 2018
Unfortunately, looking at both those lines in the code, they are both 3 argument functions. Your build is using an updated version of one file, and an outdated version of the other. Note that both methods take three arguments: https://cs.chromium.org/chromium/src/chrome/browser/net/chrome_network_delegate.h?type=cs&q=er/net/chrome_network_delegate.h&sq=package:chromium&g=0&l=182 https://cs.chromium.org/chromium/src/net/base/network_delegate_impl.h?type=cs&q=net/base/network_delegate_impl.h&sq=package:chromium&g=0&l=85 So either your local build files are incorrect, or jumbo is somehow using an outdated version of the code (Chrome/browser does indeed have a dependency on net/, so not a missing deps, at least in BUILD.gn files). Either way, the CL in question seems fine.
,
Jun 29 2018
thank you for this analysis, but what's the probability, that all branches which I tried are broken in the same time or place? it's almost equal 0 and I will highly appreciate if you could check it on your side and reject or take bug. this can be Jumbo or combination of build params or whatever and I'm sure, that you have more resources than I for checking and fixing.
,
Jun 29 2018
It's working the tree fine. The build error is nonsensical, given the code. I think the issue is most likely on your end, unless we get other reports of it.
,
Jun 29 2018
Also worth noting that neither file is dynamically generated, nor has either file moved in years. Suppose it's also possible there's a pre-existing issue with the gn dependencies / files lists, but if so, I'm not seeing it.
,
Jul 6
I'm going to close this since we haven't had any more reports of this breakage. If we get other reports of this, I'll reopen. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mar...@mwiacek.com
, Jun 28 2018