New issue
Advanced search Search tips

Issue 857275 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 812040



Sign in to add a comment

Add offline Play Store terms of service

Project Member Reported by agawronska@chromium.org, Jun 28 2018

Issue description

For offline demo mode we need the offline version of localized Play Store terms of service displayed.
 
Blocking: 812040
Labels: OS-Chrome
Labels: -M-69 M-70
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Aga, can you circle back to this issue this week?
Ok. I will.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/8c21023e6820b4901b89807393adbd5d89285b47

commit 8c21023e6820b4901b89807393adbd5d89285b47
Author: Aga Wronska <agawronska@google.com>
Date: Tue Sep 18 21:04:05 2018

Labels: -M-70 M-71
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f14a932404f9856d61c29d0cfc722e2ce1383c07

commit f14a932404f9856d61c29d0cfc722e2ce1383c07
Author: Aga Wronska <agawronska@chromium.org>
Date: Wed Sep 19 15:44:50 2018

Load Play Store terms from the disc  during offline Demo Mode setup.

Offline ToS are loaded if attempt to load online content fails.
Play Store ToS are region dependent. The proper version is decided
based on language from chosen locale and device region from the VPD.

Dedicated resources are used for most of the regions targeted by v1
Demo Mode:
  * Belgium: nl-BE, fr-BE
  * Finland: fi-FI
  * Sweden: sv-SE
  * Norway: nb-NO
  * Denmark: da-DK
  * France: fr-FR
  * Ireland: en-IE
  * Netherlands: nl-NL
  * Canada: en-CA, fr-CA
  * US: en-US
  * UK - en-GB
  * Luxembourg: eu (no dedicated terms available for de-LU nor fr-LU)

The other regions use default resources:
  * EMEA: emea
  * EU: eu
  * APAC: apac
  * AMERICAS: en-US
  * Germany: de
  * South Korea: kr
  * Anything else defaults to en-US

Information about VPD regions:
https://storage.googleapis.com/chromeos-factory-docs/sdk/regions.html#available-regions

If Demo Mode expands the list of targeted regions dedicated resources
should be added for the new regions.

Bug:  857275 
Test: Run wizard controller and demo setup browser tests.
      Run about_ui_unittest.
      Manually perform offline demo mode setup.

Change-Id: I556f08720f6214f1b33be09af9ac232c103b2f14
Reviewed-on: https://chromium-review.googlesource.com/1211737
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592416}
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/chromeos/login/demo_mode/demo_setup_browsertest.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/resources/chromeos/arc_support/playstore.css
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/resources/chromeos/login/oobe.js
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[add] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/resources/chromeos/login/web_view_helper.js
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/ui/webui/about_ui.h
[add] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/ui/webui/about_ui_unittest.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/common/url_constants.cc
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/common/url_constants.h
[modify] https://crrev.com/f14a932404f9856d61c29d0cfc722e2ce1383c07/chrome/test/BUILD.gn

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19

Labels: -Pri-1 -M-71 M-72 Pri-2
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a5b7a65eaa6c479c9a325b2775270172cc11b2e

commit 5a5b7a65eaa6c479c9a325b2775270172cc11b2e
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Sep 27 00:49:52 2018

Load Play Store privacy policy from the disk during offline Demo Mode setup.

      Run about_ui_unittest.
      Manually perform offline demo mode setup.

Bug:  857275 
Test: Run wizard controller and demo setup browser tests.
Change-Id: Ife8f6daa3d8fb87f2adf31350845efa67463b939
Reviewed-on: https://chromium-review.googlesource.com/1244476
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594545}
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/browser/resources/chromeos/login/oobe_screen_eula.js
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/browser/resources/chromeos/login/web_view_helper.js
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/browser/ui/webui/about_ui_unittest.cc
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/common/url_constants.cc
[modify] https://crrev.com/5a5b7a65eaa6c479c9a325b2775270172cc11b2e/chrome/common/url_constants.h

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/8e5e7a24541d19d0d149e119ba9f0bec954f9b56

commit 8e5e7a24541d19d0d149e119ba9f0bec954f9b56
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Sep 28 02:44:29 2018

Status: Fixed (was: Started)

Sign in to add a comment