Fix alignment of chevrons with checkboxes & toggle |
||
Issue descriptionSee this thread for more background: https://groups.google.com/a/google.com/forum/#!topic/project-unity/5Cqe-3Pudzw We should tweak the alignment of the chevrons in Clank preferences for the "standard layout" so that they are center-aligned with checkboxes.
,
Jun 28 2018
Screenshots of the updated layout.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b005c86c3d39e64c0acd762c040f6a37c17df2bb commit b005c86c3d39e64c0acd762c040f6a37c17df2bb Author: Boris Sazonov <bsazonov@chromium.org> Date: Thu Jun 28 15:02:16 2018 [Android] Change checkable_image_view_widget size This CL increases CheckableImageView size specified in checkable_image_view_widget.xml to match the size of standard checkbox widget and fix alignment. Bug: 857267 Change-Id: I6beb61a6d7d27092b3a491b3e8e2c9ee962f69ae Reviewed-on: https://chromium-review.googlesource.com/1118272 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571126} [modify] https://crrev.com/b005c86c3d39e64c0acd762c040f6a37c17df2bb/chrome/android/java/res/layout/checkable_image_view_widget.xml
,
Jun 28 2018
Woah, thanks for landing this quickly Boris! Would you mind showing a screenshot of what this now looks like with the customized layout for the checkboxes on the same device? Theoretically, everything should be perfectly aligned even with the custom layout/indentation now, right?
,
Jun 28 2018
To clarify on my comment above: I'm looking at this screenshot: https://drive.google.com/open?id=1tjSqyqlOOi1CUgRI8KmpN45Z3-mN9tFB. Since the subsection header and the top-level toggle use the standard layout, I would imagine that this fix would apply to them and the chevron would shift to the left to be aligned with the checkboxes + toggle. Is that right?
,
Jul 6
Can someone confirm if the checkbox and drop down arrow assets are the latest material assets? (should be 24x24dp including the bounding box, and 16dp from the right edge). The toggle asset is going to be difficult to align as it changes based on state (looks aligned when toggled on). Is it currently centered or right aligned with 16dp padding from the edge? Misalignment with the toggle is more forgivable here OK as it is separated by a div line, and has different functionality/states than the other icons.
,
Jul 6
I think both of those are questions for Boris, who is unfortunately OOO for the next few weeks now. Maybe Theresa or Ted can answer the questions in his absence by looking at what kind of checkboxes Boris is using in the current Unity implementation.
,
Jul 9
We don't provide our own checkbox and toggle assets. These come from the Android platform itself. The arrow is using ic_expand_less_black_24dp, which is the expand/collapse icon we use for other UI such as the NTP opt-out. The icon was added here: https://chromium-review.googlesource.com/952542
,
Jul 26
Hannah, my CL has changed the padding for chevrons to match the standard padding of checkboxes - please see the second screenshot in #c2. The actual margin from the right edge of the screen is 20dp for both chevron and checkbox.
,
Jul 27
Thanks so much for working on this! As the padding to the right of the help icon in the header is 16dp, is there any way to decrease it for all the other icons from 20 to 16dp as well? (This is a standard for all our list styles with icons on the right).
,
Jul 27
The help icon in the header is general settings design. We use the Android ActionBar widget so we have somewhat limited control here, but will you please file a separate P3 polish bug for the frontend team?
,
Jul 27
Sorry, my poor wording: I meant that we should change the check boxes to from 20 to 16dp to match the header because of the reasons you mentioned. (not that we change the header)! |
||
►
Sign in to add a comment |
||
Comment 1 by twelling...@chromium.org
, Jun 28 2018195 KB
195 KB View Download
96.3 KB
96.3 KB View Download