New issue
Advanced search Search tips

Issue 857265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 161072



Sign in to add a comment

Web Locks API: Upstream tests to WPT

Project Member Reported by jsb...@chromium.org, Jun 27 2018

Issue description

Upstream third_party/WebKit/LayoutTests/http/tests/locks to web-platform-tests/wpt

Everything in there should be upstreamable without changes except chromium-waiting-promise-gc.html


 

Comment 1 by jsb...@chromium.org, Jun 27 2018

Blocking: 161072

Comment 2 by jsb...@chromium.org, Jun 28 2018

Okay, a couple more things:

* The service worker IDL test relies on a helper that may not be present. May need to copy it.
* The tests navigate themselves to an HTTPS origin. For WPT they should just get renamed with a .https infix

Comment 3 by jsb...@chromium.org, Jun 28 2018

Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ec1f2bebc07b854a476a81a6edd0341691fdfa0

commit 4ec1f2bebc07b854a476a81a6edd0341691fdfa0
Author: Joshua Bell <jsbell@chromium.org>
Date: Tue Jul 10 23:42:35 2018

Web Locks API: Upstream tests to web-platform-tests (as .tentative)

* Move tests from http/tests/locks to external/wpt/web-locks
* Name with '.tentative' infix since this is still just a proposal
* Name most tests with '.https' infix since feature is [SecureContext]
   (and remove redirect-to-secure-host logic in tests)
* Consolidate window/worker interfaces test with '.any.js' variant
* Update paths to service worker helpers

Bug:  857265 
Change-Id: Iaf254c5d53ff5b6bb65de4516df85307ad3a6519
Reviewed-on: https://chromium-review.googlesource.com/1118764
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573991}
[add] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/META.yml
[add] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/OWNERS
[add] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/README.md
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/acquire.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/clientids.tentative.https-expected.txt
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/clientids.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/frames.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/held.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/ifAvailable.tentative.https.html
[add] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/interfaces-serviceworker.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/interfaces.idl
[copy] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/interfaces.tentative.https.any.js
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/lock-attributes.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-exclusive.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-mixed.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-shared.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/non-secure-context.tentative.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/opaque-origin.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/query-empty.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/query-order.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/query.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resource-names.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resources/helpers.js
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resources/iframe.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resources/interfaces-serviceworker.js
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resources/service-worker.js
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resources/sw-controlled-iframe.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/resources/worker.js
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/secure-context.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/signal.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/steal.tentative.https.html
[rename] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/external/wpt/web-locks/workers.tentative.https.html
[add] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/http/tests/locks/README.md
[modify] https://crrev.com/4ec1f2bebc07b854a476a81a6edd0341691fdfa0/third_party/WebKit/LayoutTests/http/tests/locks/chromium-waiting-promise-gc.html
[delete] https://crrev.com/6e5a781942cb121156c80416b116653995399ba8/third_party/WebKit/LayoutTests/http/tests/locks/interfaces-serviceworker.html
[delete] https://crrev.com/6e5a781942cb121156c80416b116653995399ba8/third_party/WebKit/LayoutTests/http/tests/locks/interfaces-worker.html
[delete] https://crrev.com/6e5a781942cb121156c80416b116653995399ba8/third_party/WebKit/LayoutTests/http/tests/locks/interfaces.html

Sign in to add a comment