New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857263 link

Starred by 6 users
Status: Started
Owner:
campello@chromium.org
Cc:
bleung@chromium.org
█ dtor@chromium.org
█ vmreyes@google.com
vapier@chromium.org
█ saludlemus@google.com
tbroch@chromium.org
dlaurie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on: View detail
issue 398786
issue 862390
issue 865741
issue 866111
issue 864742
Blocking:
issue 860085



Sign in to add a comment

Integrate fwupd package into chromeOS.

Project Member Reported by vmreyes@google.com, Jun 27 2018 
Chrome Version: <69.0.3464.0>
Chrome OS Version: <10799.0.2018_06_19_1616>
Chrome OS Platform: <GOOGLE-EVE>
Network info: <N/A>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Cr-OS-Kernel

Steps To Reproduce:
(1) N/A
(2)
(3)

Expected Result:
Implement fwupd package into chromeOS.

Comment 1 by bleung@chromium.org, Jun 28 2018

Cc: saludlemus@google.com bleung@chromium.org dtor@chromium.org tbroch@chromium.org dlaurie@chromium.org
Components: OS>Kernel Internals>Installer
Status: Available (was: Unconfirmed)

Comment 2 by bleung@chromium.org, Jun 28 2018 

Thanks for filing this, Victor.

Todd, Dmitry, Duncan, this will track adding fwupd to chromiumos.

Comment 3 by bleung@chromium.org, Jun 28 2018

Labels: -Type-Bug Type-Feature

Comment 4 by bleung@chromium.org, Jun 28 2018

Cc: vapier@chromium.org

Comment 5 by bleung@chromium.org, Jul 10

Blockedon: 862390
Components: OS>Packages
Blocked on issue 862390, dev-lang spidermonkey fails.

Comment 6 by bleung@chromium.org, Jul 10

Cc: vmreyes@google.com

Comment 7 by bleung@chromium.org, Jul 10

Blocking: 860085
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/e1702798366eff9e82ba4447313a035ca97cd871

commit e1702798366eff9e82ba4447313a035ca97cd871
Author: Benson Leung <bleung@chromium.org>
Date: Fri Jul 20 12:31:24 2018
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/4512236b935c6d92cec7d3e85494cdb9553e962c

commit 4512236b935c6d92cec7d3e85494cdb9553e962c
Author: Benson Leung <bleung@chromium.org>
Date: Fri Jul 20 12:31:18 2018

Add fwupd repo to third_party

Signed-off-by: Benson Leung <bleung@chromium.org>

BUG=chromium:857263,chromium:864742
TEST=repo sync. Check that fwupd appears in src/third_party

Change-Id: I2f34c74a3c83d9231f4da781f3c06305787faf0b
Reviewed-on: https://chromium-review.googlesource.com/1144276
Commit-Ready: Benson Leung <bleung@google.com>
Tested-by: Benson Leung <bleung@google.com>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/4512236b935c6d92cec7d3e85494cdb9553e962c/full.xml

Comment 10 by bleung@chromium.org, Jul 20

Blockedon: 864742

Comment 11 by bleung@chromium.org, Jul 20

Blockedon: 865741

Comment 12 by bleung@chromium.org, Jul 20

Blockedon: 866111
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/67f65bd2ad8c809519bf2f5b5f59892e8bff27d1

commit 67f65bd2ad8c809519bf2f5b5f59892e8bff27d1
Author: Benson Leung <bleung@chromium.org>
Date: Sat Jul 21 01:34:05 2018

CHROMIUM: fwupd: Add README.chromium

Signed-off-by: Benson Leung <bleung@chromium.org>

BUG=chromium:857263,chromium:864742
TEST=None. Just a readme change.

Change-Id: Ied4ca8259a925ea8ab989dbc66c383c813dec9ee
Reviewed-on: https://chromium-review.googlesource.com/1144440
Commit-Ready: Benson Leung <bleung@chromium.org>
Tested-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[add] https://crrev.com/67f65bd2ad8c809519bf2f5b5f59892e8bff27d1/README.chromium
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/7be412986d8e41c6f243a1c580b688d4e2057f80

commit 7be412986d8e41c6f243a1c580b688d4e2057f80
Author: Victor Reyes <vmreyes@google.com>
Date: Thu Jul 26 02:45:43 2018

libproxy: upgraded package to upstream

Upgraded net-libs/libproxy to version 0.4.13-r2 on amd64

BUG=chromium:857263
TEST=emerge-eve net-libs/libproxy
CQ-DEPEND=CL:1123323

Change-Id: I178db214cdddedbf4e67243865a2bbda8645d326
Signed-off-by: Victor Reyes <vmreyes@google.com>
Signed-off-by: Salud Lemus <saludlemus@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1123334
Commit-Ready: Victor Reyes Espinoza <vmreyes@google.com>
Tested-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>

[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/files/proxy.1
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/files/libproxy-0.4.12-mozjs.pc.patch
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/libproxy-0.4.13-r2.ebuild
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/Manifest
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/files/libproxy-0.4.12-macosx.patch
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/metadata.xml
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/files/libproxy-0.4.11-avoid-nm-build-dep.patch
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/metadata/md5-cache/net-libs/libproxy-0.4.13-r2
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/files/libproxy-0.4.10-disable-pac-test.patch
[add] https://crrev.com/7be412986d8e41c6f243a1c580b688d4e2057f80/net-libs/libproxy/files/libproxy-0.4.13-cmake-37.patch
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/b45f401f7cd6bd5a49f2aa5bc6d50fe5b70eb0a6

commit b45f401f7cd6bd5a49f2aa5bc6d50fe5b70eb0a6
Author: Victor Reyes <vmreyes@google.com>
Date: Thu Jul 26 02:45:26 2018

xdg-utils: Updated xdg-utils eclass to upstream

BUG=chromium:857263
TEST=Trybots verification

Change-Id: I93e709a085c1f673f727b1cb8fd7b89bba7915ab
Reviewed-on: https://chromium-review.googlesource.com/1145641
Commit-Ready: Victor Reyes Espinoza <vmreyes@google.com>
Tested-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/b45f401f7cd6bd5a49f2aa5bc6d50fe5b70eb0a6/eclass/xdg-utils.eclass
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d0e31ce4becf964f5811dfa54bce68d88921f95d

commit d0e31ce4becf964f5811dfa54bce68d88921f95d
Author: Victor Reyes <vmreyes@google.com>
Date: Fri Jul 27 06:59:47 2018

profile: Updated gettext version in package.provided

Necessary change to emerge gettext-0.19.8.1 on eve

BUG=chromium:857263
TEST=emerge-eve gettext

Change-Id: I02c93e516db41caba4c963c8fe18d1ec428fdac9
Reviewed-on: https://chromium-review.googlesource.com/1151753
Commit-Ready: Victor Reyes Espinoza <vmreyes@google.com>
Tested-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d0e31ce4becf964f5811dfa54bce68d88921f95d/profiles/targets/chromeos/package.provided
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/d817b3ed79957a18fea0c94ae16f11432b4180d2

commit d817b3ed79957a18fea0c94ae16f11432b4180d2
Author: Victor Reyes <vmreyes@google.com>
Date: Tue Jul 31 06:08:18 2018

xdg: Updated xdg eclass to upstream

Updated xdg.eclass to 61b861acd7b49083dab687e133f30f3331cb7480 (latest)

BUG=chromium:857263
TEST=trybots verification

Change-Id: I28a7a225677f1263604a85d4acf1b0820763f848
Reviewed-on: https://chromium-review.googlesource.com/1145643
Commit-Ready: Victor Reyes Espinoza <vmreyes@google.com>
Tested-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/d817b3ed79957a18fea0c94ae16f11432b4180d2/eclass/xdg.eclass
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/739df01e17330e95bc3753e66dffcf8bb5c781b7

commit 739df01e17330e95bc3753e66dffcf8bb5c781b7
Author: Victor Reyes <vmreyes@google.com>
Date: Tue Jul 31 23:37:26 2018

libseccomp: upgraded package to upstream

Upgraded sys-libs/libseccomp to version 2.3.3 on amd64

BUG=chromium:857263
TEST=emerge-eve libseccomp

Change-Id: Ia0497517a9e0eb0aeffa111bc98ec5c056d10baf
Reviewed-on: https://chromium-review.googlesource.com/1155374
Commit-Ready: Victor Reyes Espinoza <vmreyes@google.com>
Tested-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/739df01e17330e95bc3753e66dffcf8bb5c781b7/metadata/md5-cache/sys-libs/libseccomp-2.3.3
[modify] https://crrev.com/739df01e17330e95bc3753e66dffcf8bb5c781b7/sys-libs/libseccomp/metadata.xml
[modify] https://crrev.com/739df01e17330e95bc3753e66dffcf8bb5c781b7/sys-libs/libseccomp/Manifest
[rename] https://crrev.com/739df01e17330e95bc3753e66dffcf8bb5c781b7/sys-libs/libseccomp/libseccomp-2.3.3.ebuild
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/a3967cdcecbdf96d4e82484ae399b38c34a6da86

commit a3967cdcecbdf96d4e82484ae399b38c34a6da86
Author: Victor Reyes <vmreyes@google.com>
Date: Sat Aug 11 05:44:07 2018

vala-common: upgraded package to upstream

Upgraded dev-libs/vala-common to version 0.36.13 on amd64

BUG=chromium:857263
TEST=emerge-eve dev-libs/vala-common

Change-Id: I5b09ee1a4645457cf3276ed736680581656c19c9
Signed-off-by: Victor Reyes <vmreyes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1125135
Commit-Ready: Victor Reyes Espinoza <vmreyes@google.com>
Tested-by: Victor Reyes Espinoza <vmreyes@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/a3967cdcecbdf96d4e82484ae399b38c34a6da86/metadata/md5-cache/dev-libs/vala-common-0.36.13
[add] https://crrev.com/a3967cdcecbdf96d4e82484ae399b38c34a6da86/dev-libs/vala-common/metadata.xml
[add] https://crrev.com/a3967cdcecbdf96d4e82484ae399b38c34a6da86/dev-libs/vala-common/Manifest
[add] https://crrev.com/a3967cdcecbdf96d4e82484ae399b38c34a6da86/dev-libs/vala-common/vala-common-0.36.13.ebuild
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 21

Labels: merge-merged-fwupd-1.0.6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/011a2df0e717ba6857e0b4b86705d531a8fd3cbf

commit 011a2df0e717ba6857e0b4b86705d531a8fd3cbf
Author: Benson Leung <bleung@chromium.org>
Date: Tue Aug 21 04:43:02 2018

CHROMIUM: fwupd: Add README.chromium

Signed-off-by: Benson Leung <bleung@chromium.org>

BUG=chromium:857263,chromium:864742
TEST=None. Just a readme change.

Reviewed-on: https://chromium-review.googlesource.com/1144440
Commit-Ready: Benson Leung <bleung@chromium.org>
Tested-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>
(cherry picked from commit 67f65bd2ad8c809519bf2f5b5f59892e8bff27d1)
Signed-off-by: Benson Leung <bleung@chromium.org>

Change-Id: Ied4ca8259a925ea8ab989dbc66c383c813dec9ee
Reviewed-on: https://chromium-review.googlesource.com/1180177
Commit-Ready: Benson Leung <bleung@chromium.org>
Tested-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[add] https://crrev.com/011a2df0e717ba6857e0b4b86705d531a8fd3cbf/README.chromium
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/9b5f176fefc97906eebcea9df2cab0b477352072

commit 9b5f176fefc97906eebcea9df2cab0b477352072
Author: Richard Hughes <richard@hughsie.com>
Date: Tue Aug 21 04:43:00 2018

UPSTREAM: trivial: Fix a compile warning when ConsoleKit and systemd are disabled

Fixes an issue where the argument was a triple pointer instead
of a double pointer.

BUG=chromium:857263
TEST=No compiler warning about an incorrect pointer argument

(cherry picked from commit a7689dab339d3b35150827756a29c5a6e715651a
https://github.com/hughsie/fwupd.git 1_0_X)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: Id8ac7226cc0b0482aeca06fa2c4fa628a87d9aef
Reviewed-on: https://chromium-review.googlesource.com/1180522
Commit-Ready: Salud Lemus <saludlemus@google.com>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@google.com>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/9b5f176fefc97906eebcea9df2cab0b477352072/src/fu-util.c
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/1de65415b4390572a2a5626f62b3f2b9f208d7f6

commit 1de65415b4390572a2a5626f62b3f2b9f208d7f6
Author: Richard Hughes <richard@hughsie.com>
Date: Tue Aug 21 04:42:59 2018

UPSTREAM: trivial: Fix a build warning when building without ConsoleKit support

Fixes a compiler warning for HAVE_CONSOLEKIT macro being undefined

BUG=chromium:857263
TEST=No compiler warning about HAVE_CONSOLEKIT macro being undefined

(cherry picked from commit db7dfae566451ef3e78723d3e8322078282ade73
https://github.com/hughsie/fwupd.git 1_0_X)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: Ia20d328ed48fa5f6ee27b1e0197266227c66b5ad
Reviewed-on: https://chromium-review.googlesource.com/1181523
Commit-Ready: Salud Lemus <saludlemus@google.com>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/1de65415b4390572a2a5626f62b3f2b9f208d7f6/src/fu-util.c
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0926fea4aad84bde5b97fa1f206ec5fe50be35fc

commit 0926fea4aad84bde5b97fa1f206ec5fe50be35fc
Author: Salud Lemus <saludlemus@google.com>
Date: Tue Aug 21 04:43:01 2018

sys-apps/fwupd: Create a directory in chromiumos-overlay for 9999 ebuild

* Copy contents over from portage-stable to chromiumos-overlay.
* Change version to 9999
* Inherit cros-workon, and set CROS_WORKON variables.
* Add python2_7 to PYTHON_COMPAT
* Add chromeos-version.sh that determines the latest package's version
* Mask the cros workon ebuild
* Add consolekit USE flag, logic behavior, and usex behavior
for consolekit and systemd

BUG=chromium:857263
TEST=precq passes

Change-Id: I96e09067e611ab17a159df933ec5ab612d1f7057
Reviewed-on: https://chromium-review.googlesource.com/1170222
Commit-Ready: Salud Lemus <saludlemus@google.com>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@google.com>

[add] https://crrev.com/0926fea4aad84bde5b97fa1f206ec5fe50be35fc/sys-apps/fwupd/files/chromeos-version.sh
[add] https://crrev.com/0926fea4aad84bde5b97fa1f206ec5fe50be35fc/sys-apps/fwupd/Manifest
[add] https://crrev.com/0926fea4aad84bde5b97fa1f206ec5fe50be35fc/sys-apps/fwupd/fwupd-9999.ebuild
[add] https://crrev.com/0926fea4aad84bde5b97fa1f206ec5fe50be35fc/sys-apps/fwupd/metadata.xml
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/13306881746ac47f04c4b8718eef03f042fb3a77

commit 13306881746ac47f04c4b8718eef03f042fb3a77
Author: Richard Hughes <richard@hughsie.com>
Date: Fri Sep 07 18:03:21 2018

UPSTREAM: Fix flashing devices that require a manual replug

We were looking for 'active' and 'old' devices with a specific ID. Due to a
copy and paste thinko we were actually matching the active list twice,
triggering the 'device ID was not unique' failure.

Fixes half of https://github.com/hughsie/fwupd/issues/565

BUG=chromium:857263
TEST=plug in updatable device and check the number of Guids, and then
unplug and put the device into updatable mode. Plug in the device back, and check
that the number Guids either increased or stayed the same

(cherry picked from commit 45779074fc608727869dff029006c46310fe5b4e
https://github.com/hughsie/fwupd.git 1_0_X)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: I5d3392fa7ac04af5c2c87bc89b103d3eb4e07624
Reviewed-on: https://chromium-review.googlesource.com/1187233
Commit-Ready: Salud Lemus <saludlemus@google.com>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/13306881746ac47f04c4b8718eef03f042fb3a77/src/fu-device-list.c
Project Member

Comment 29 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/e4c3fbc112614c00f3d83f15828c57d83139ea5a

commit e4c3fbc112614c00f3d83f15828c57d83139ea5a
Author: Richard Hughes <richard@hughsie.com>
Date: Fri Sep 07 21:28:59 2018

UPSTREAM: trivial: Show the VID and PID when failing to add a USB device

Fixes https://github.com/hughsie/fwupd/issues/476

BUG=chromium:857263
TEST=source code compiles

(cherry picked from commit e598fc344788e8e36bb09e3f4df9285ce0eb8987
https://github.com/hughsie/fwupd.git master)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: I1e06bffd596c55e71d86fdb5c40489cd9f44841a
Reviewed-on: https://chromium-review.googlesource.com/1191680
Commit-Ready: Salud Lemus <saludlemus@google.com>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/e4c3fbc112614c00f3d83f15828c57d83139ea5a/plugins/dfu/dfu-device.c
[modify] https://crrev.com/e4c3fbc112614c00f3d83f15828c57d83139ea5a/src/fu-engine.c
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/976c14ff555b64bd33d3ad9830bf3e0e7cfc03ab

commit 976c14ff555b64bd33d3ad9830bf3e0e7cfc03ab
Author: Richard Hughes <richard@hughsie.com>
Date: Fri Sep 07 21:28:59 2018

UPSTREAM: trivial: Split out some common keyring functionality

BUG=chromium:857263
TEST=source code compiles

(cherry picked from commit 7383ce263b95731c257f0c2d748ca2d87fe32c8b
https://github.com/hughsie/fwupd.git master)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: Ia94c1f64b6b4fbb874e3682cae9b0f09656c7f92
Reviewed-on: https://chromium-review.googlesource.com/1191681
Commit-Ready: Salud Lemus <saludlemus@google.com>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/976c14ff555b64bd33d3ad9830bf3e0e7cfc03ab/src/meson.build
[add] https://crrev.com/976c14ff555b64bd33d3ad9830bf3e0e7cfc03ab/src/fu-keyring-utils.c
[add] https://crrev.com/976c14ff555b64bd33d3ad9830bf3e0e7cfc03ab/src/fu-keyring-utils.h
[modify] https://crrev.com/976c14ff555b64bd33d3ad9830bf3e0e7cfc03ab/src/fu-engine.c
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/f135051b85261b64d10d57b519670d72fc796fd1

commit f135051b85261b64d10d57b519670d72fc796fd1
Author: Richard Hughes <richard@hughsie.com>
Date: Mon Sep 10 20:33:40 2018

UPSTREAM: trivial: Don't show a critical warning for an invalid firmware file

If the file has <release> without a <checksum type="content"> then we shouldn't
log a critical warning.

BUG=chromium:857263
TEST=source code compiles

(cherry picked from commit ca81d785978bf49789a05b5be3ef39d85a7ebd10
https://github.com/hughsie/fwupd.git master)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: I8076b296dc818d5c0c71434457941f676032d2d1
Reviewed-on: https://chromium-review.googlesource.com/1191782
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/f135051b85261b64d10d57b519670d72fc796fd1/src/fu-keyring-utils.c
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/6af38f2ece9b95de6717b691545c00532648feea

commit 6af38f2ece9b95de6717b691545c00532648feea
Author: Richard Hughes <richard@hughsie.com>
Date: Mon Sep 10 20:33:40 2018

BACKPORT: Allow installing more than one firmware using 'fwupdmgr install'

When using failed to open firmware.cab we pass in a device ID of '*' which
tells the daemon to update anything that matches. The current implementation
will fail in two ways:

* If duplicate hardware is installed (for instance two Unifying receivers) then
  only the first matching device will be updated.

* If the firmware archive contains two different images then we only try and
  upgrade the first device that matches. This means we're unable to update
  composite devices using one firmware file.

To fix both issues, carefully build a list of tasks that can be processed using
the given firmware and installed devices, request authentication using all the
different action IDs, then upgrade all the devices one-at-a-time.

Based on a patch by Mario Limonciello <mario.limonciello@dell.com>, many thanks.

Compiler warning about no function declaration for "fu_engine_check_requirements,"
under fu-engine.c, so add it to the header file of "fu-engine.h"

Did not remove the function "_as_app_get_release_by_version" because the patch assumes we have a version
of appstream-glib greater than or equal to 0.7.3. It would use a function that
does not exist in 0.6.13 of appstream-glib.

BUG=chromium:857263
TEST=No compiler warning about missing function declaration

(cherry picked from commit 4ad41f027c0d04ac395b70077e9da7b63b14fd43
https://github.com/hughsie/fwupd.git master)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: I40d25dda15d5c1b2323d3a51f910d01dfdd5c4f6
Reviewed-on: https://chromium-review.googlesource.com/1191783
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/fu-main.c
[add] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/fu-install-task.h
[add] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/fu-install-task.c
[modify] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/fu-engine.h
[modify] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/fu-self-test.c
[modify] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/meson.build
[modify] https://crrev.com/6af38f2ece9b95de6717b691545c00532648feea/src/fu-engine.c
Project Member

Comment 33 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/de06e79b0296adc38d51a3c920de90c115a63c1d

commit de06e79b0296adc38d51a3c920de90c115a63c1d
Author: Mario Limonciello <mario.limonciello@dell.com>
Date: Tue Sep 11 00:17:39 2018

UPSTREAM: fu-install-task: Don't fail update installation if compiled without GPG/PKCS7

Currently if you download a CAB file from LVFS and try to install it
on a daemon compiled without GPG it will fail to install since LVFS has signed
it.  You had to make an intentional decision to disable GPG.

Allow this scenario to work just as if the CAB file were unsigned, but save
a warning in the logs that it happened.

BUG=chromium:857263
TEST=fwupdmgr install <cab file> does not output an error
regarding "Not compiled with GPG support"
Running "/usr/libexec/fwupd/fupwd -v" for the install option
shows that the verification step is ignored for the device

(cherry picked from commit 7d35278cb637f03354ca589849dcf51dc0c07dbf
https://github.com/hughsie/fwupd.git master)
Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: I8dc844243b3304ad42517b02fdbf0d1faf311811
Reviewed-on: https://chromium-review.googlesource.com/1191784
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/de06e79b0296adc38d51a3c920de90c115a63c1d/src/fu-install-task.c
Project Member

Comment 34 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/fwupd/+/8fa99b87bc6420d0cd2884ce7ced03c623d7d4ad

commit 8fa99b87bc6420d0cd2884ce7ced03c623d7d4ad
Author: Salud Lemus <saludlemus@google.com>
Date: Tue Sep 11 00:17:39 2018

UPSTREAM: fu-engine: Don't fail get-details if compiled without GPG/PKCS7

Similar to commit 7d35278 regarding the install option with a daemon compiled without
GPG, but now, if you also have a daemon compiled without GPG, and if you have downloaded a
CAB file from LVFS and ran get-details, it would fail to display the contents
of the associated CAB file.

This allows it to still display the contents of the CAB file, and
a warning will be displayed in the logs.

BUG=chromium:857263
TEST=fwupdmgr get-details <cab file> does not show "Not compiled with GPG support"
and running "/usr/libexec/fwupd/fwupd -v" for the get-details option shows that
the verification step is ignored for the CAB file

(cherry-picked from commit 980f2d95519a163fe49797259e94e2b29a3c341d
https://github.com/hughsie/fwupd.git master)

Signed-off-by: Salud Lemus <saludlemus@google.com>

Change-Id: I2ce3d4da96a3a48ed3e9a38477ca6270b3537a22
Reviewed-on: https://chromium-review.googlesource.com/1191929
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Salud Lemus <saludlemus@google.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/8fa99b87bc6420d0cd2884ce7ced03c623d7d4ad/src/fu-engine.c

Comment 35 by vapier@chromium.org, Sep 13

Blockedon: 398786

Comment 38 by sjg@chromium.org, Dec 17 

Hi, is this bug nearing completion?

Comment 39 by vapier@chromium.org, Dec 17 

i don't think it's close.  fwupd itself needs a lot of work still.

Comment 40 by campello@chromium.org, Jan 7

Owner: campello@chromium.org
Status: Started (was: Available)

Comment 41 by mario_li...@dell.com, Jan 7 

@campello,
Regarding issue 398786 which is a blocker, I believe if you disable the UEFI plugin for CrOS you shouldn't need to bring in PIL/pillow.
Project Member

Comment 42 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/eb6b108a4a96a6357c5422f7bf078d3c1f42cca9

commit eb6b108a4a96a6357c5422f7bf078d3c1f42cca9
Author: Daniel Campello <campello@chromium.org>
Date: Fri Jan 11 21:32:29 2019
Project Member

Comment 43 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/1f76f71df1e111dba793365d7dd4a4ab467954f9

commit 1f76f71df1e111dba793365d7dd4a4ab467954f9
Author: Daniel Campello <campello@chromium.org>
Date: Fri Jan 11 21:32:28 2019

fwupd: anchor to 1.2.3

BUG=chromium:857263
TEST=repo sync. Check that fwupd's m/master points to
fwupd-1.2.3

Change-Id: I6bf40b61ba619fec737223d5f81f20d04ca9acb0
Reviewed-on: https://chromium-review.googlesource.com/1405451
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/1f76f71df1e111dba793365d7dd4a4ab467954f9/full.xml
Project Member

Comment 44 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e324eb413f1bd1ce2422f2d0c8db038d9775b56d

commit e324eb413f1bd1ce2422f2d0c8db038d9775b56d
Author: Daniel Campello <campello@chromium.org>
Date: Mon Jan 14 21:15:57 2019

qemu: move flags from default/linux to target/sdk

This makes sure that we do not use static-libs in chromeos profile

BUG=chromium:857263,b/121131967
TEST=emerge-sarien fwupd

Change-Id: I3d2680cd89a2d642c8adc761c87da984b00bcc92
Reviewed-on: https://chromium-review.googlesource.com/1407814
Commit-Ready: Daniel Campello <campello@chromium.org>
Tested-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e324eb413f1bd1ce2422f2d0c8db038d9775b56d/profiles/targets/sdk/package.use
[modify] https://crrev.com/e324eb413f1bd1ce2422f2d0c8db038d9775b56d/profiles/default/linux/package.use
Project Member

Comment 45 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/67bc6cdaa78ac62c18477b942d600e5369891695

commit 67bc6cdaa78ac62c18477b942d600e5369891695
Author: Daniel Campello <campello@chromium.org>
Date: Tue Jan 15 19:52:39 2019

sys-apps/fwupd: update to 1.2.3

Updated to version 1.2.3
Created daemon introspection and synaptics use flags
Drop >=meson-0.47 requirement until python-3.6 is available on the SDK

BUG=chromium:857263,b:121131967
TEST=emerge-sarien fwupd

Change-Id: Ic72cb8e1d15a3b6a6cba7baf718f426fc81488c0
Reviewed-on: https://chromium-review.googlesource.com/1401242
Commit-Ready: Daniel Campello <campello@chromium.org>
Tested-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/67bc6cdaa78ac62c18477b942d600e5369891695/sys-apps/fwupd/Manifest
[add] https://crrev.com/67bc6cdaa78ac62c18477b942d600e5369891695/sys-apps/fwupd/files/fwupd-1.2.3-meson.patch
[modify] https://crrev.com/67bc6cdaa78ac62c18477b942d600e5369891695/sys-apps/fwupd/fwupd-9999.ebuild
[modify] https://crrev.com/67bc6cdaa78ac62c18477b942d600e5369891695/sys-apps/fwupd/metadata.xml
Project Member

Comment 46 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a5c202cc5729a34d9274abb0cc6342b414e86d35

commit a5c202cc5729a34d9274abb0cc6342b414e86d35
Author: Daniel Campello <campello@chromium.org>
Date: Thu Jan 17 17:09:04 2019

fwupd: Remove USE=static-libs for libusb

Fixes the following requirement:
The following USE changes are necessary to proceed:
 (see "package.use" in the portage(5) man page for more details)
>=sys-fs/udev-225-r15 static-libs
>=virtual/libudev-215-r1 static-libs

BUG=b:121131967,chromium:857263
TEST=Trybot

Change-Id: I2aee74659eff1a3f18dd0d37fc845cd6a165767b
Reviewed-on: https://chromium-review.googlesource.com/1412613
Commit-Ready: Daniel Campello <campello@chromium.org>
Tested-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a5c202cc5729a34d9274abb0cc6342b414e86d35/project-moblab/profiles/base/package.use
[modify] https://crrev.com/a5c202cc5729a34d9274abb0cc6342b414e86d35/project-labstation/profiles/base/package.use
Project Member

Comment 47 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/83cad55244685bd6ed53018b0b9e2762030f919e

commit 83cad55244685bd6ed53018b0b9e2762030f919e
Author: Daniel Campello <campello@chromium.org>
Date: Fri Jan 18 04:20:53 2019

virtual/target-chromium-os: add sys-apps/fwupd

Added sys-apps/fwupd to the virtual/target-chromium-os
Updated USE flags needed for sys-apps/fwupd

Alse set sys-apps/util-linux -udev afert enabling udev system wide to
avoid the following dependency loop:

(virtual/libudev-215-r1:0/1::portage-stable) depends on
 (sys-fs/udev-225-r14:0/0::chromiumos) (runtime)
  (sys-apps/util-linux-2.32-r3:0/0::portage-stable) (buildtime)
   (virtual/libudev-215-r1:0/1::portage-stable) (buildtime_slot_op)

BUG=b:121131967,chromium:857263
TEST=./build_packages --board=sarien
CQ-DEPEND=CL:1412613

Change-Id: I82805d9a23c8fe43ed2e4e24f46e05b838f30f30
Reviewed-on: https://chromium-review.googlesource.com/1401243
Commit-Ready: Daniel Campello <campello@chromium.org>
Tested-by: Daniel Campello <campello@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Daniel Campello <campello@chromium.org>

[modify] https://crrev.com/83cad55244685bd6ed53018b0b9e2762030f919e/profiles/targets/chromeos/make.defaults
[rename] https://crrev.com/83cad55244685bd6ed53018b0b9e2762030f919e/virtual/target-chromium-os/target-chromium-os-1-r117.ebuild
[modify] https://crrev.com/83cad55244685bd6ed53018b0b9e2762030f919e/virtual/target-chromium-os/target-chromium-os-1.ebuild
[modify] https://crrev.com/83cad55244685bd6ed53018b0b9e2762030f919e/profiles/targets/chromeos/package.use
►

Sign in to add a comment