New issue
Advanced search Search tips

Issue 857262 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in viz::SingleReleaseCallback::Run

Project Member Reported by ClusterFuzz, Jun 27 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5516619259052032

Fuzzer: ifratric_pdf_generic
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x1205ab754110
Crash State:
  viz::SingleReleaseCallback::Run
  viz::ClientResourceProvider::RemoveImportedResource
  cc::TextureLayerImpl::FreeTransferableResource
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=570796:570798

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5516619259052032

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 27 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 27 2018

Labels: Test-Predator-Auto-Owner
Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/d0ed5774569fc56f4a0c74affafda8a7ad2a02aa (Allow TextureLayer to hold onto software resources over viz restart).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 28 2018

Labels: M-69 Target-69
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 28 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 28 2018

Labels: Pri-1

Comment 6 by danakj@chromium.org, Jun 28 2018

Cc: kylec...@chromium.org piman@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df331a0c530895fae7c4266ab5fee201a78339f4

commit df331a0c530895fae7c4266ab5fee201a78339f4
Author: danakj <danakj@chromium.org>
Date: Thu Jun 28 22:41:25 2018

Don't crash and return TextureLayer resources as not-lost on shutdown

If LayerTreeHost is destroyed while TextureLayer has a resource, it
should return that resource, not marking it as lost, and not crashing.

R=piman@chromium.org

Bug:  857262 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1e70dd4a17ca9e556d5332ee25d1fd567cb7dad7
Reviewed-on: https://chromium-review.googlesource.com/1119093
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571307}
[modify] https://crrev.com/df331a0c530895fae7c4266ab5fee201a78339f4/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/df331a0c530895fae7c4266ab5fee201a78339f4/cc/test/fake_layer_tree_host_client.cc
[modify] https://crrev.com/df331a0c530895fae7c4266ab5fee201a78339f4/cc/test/fake_layer_tree_host_client.h
[modify] https://crrev.com/df331a0c530895fae7c4266ab5fee201a78339f4/cc/trees/layer_tree_host_impl.cc

Project Member

Comment 8 by ClusterFuzz, Jun 29 2018

ClusterFuzz has detected this issue as fixed in range 571372:571373.

Detailed report: https://clusterfuzz.com/testcase?key=5516619259052032

Fuzzer: ifratric_pdf_generic
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x1205ab754110
Crash State:
  viz::SingleReleaseCallback::Run
  viz::ClientResourceProvider::RemoveImportedResource
  cc::TextureLayerImpl::FreeTransferableResource
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=570796:570798
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=571372:571373

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5516619259052032

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jun 29 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5516619259052032 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 29 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Cc: ivancic@google.com danakj@chromium.org kkaluri@chromium.org
 Issue 857434  has been merged into this issue.
Project Member

Comment 12 by ClusterFuzz, Jun 29 2018

Labels: OS-Linux
Labels: -ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 5

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment