New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857250 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

content::URLLoaderInterceptor with StoragePartition if a request is made early

Project Member Reported by jcivelli@chromium.org, Jun 27 2018 
URLLoaders created with StoragePartition::GetURLLoaderFactoryForBrowserProcess() are not intercepted by content::URLLoaderInterceptor if the interceptor is created after at least one such URLLoader was run.

This is because StoragePartition caches the SharedURLLoaderFactory, so a request made before the URLLoaderIntercpetor is created causes a non interceptor SharedURLLoaderFactory to be created and used from then on.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dcf99fc0e082e00eec1d7151652841bd2462551

commit 3dcf99fc0e082e00eec1d7151652841bd2462551
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Jun 28 01:26:47 2018

Fix for URLLoaderInterceptor with StoragePartition

Ensure we recreate the SharedURLLoaderFactory used by StoragePartition
whenever SetGetURLLoaderFactoryForBrowserProcessCallbackForTesting() is
called. This makes the URLLoaderInterceptor work properly with the
SharedURLLoaderFactory returned by
StoragePartition::GetURLLoaderFactoryForBrowserProcess().

Bug:  857250 
Change-Id: Id913ba93322dc62c2c03d8acd4c31b53fc8d436e
Reviewed-on: https://chromium-review.googlesource.com/1117822
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570995}
[modify] https://crrev.com/3dcf99fc0e082e00eec1d7151652841bd2462551/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/3dcf99fc0e082e00eec1d7151652841bd2462551/content/browser/storage_partition_impl.h
[modify] https://crrev.com/3dcf99fc0e082e00eec1d7151652841bd2462551/content/browser/storage_partition_impl_browsertest.cc

Comment 2 by jcivelli@chromium.org, Jun 28 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment