New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 857242 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD-refresh: cr-toast paper button background color issues

Project Member Reported by scottchen@chromium.org, Jun 27 2018

Issue description

There's some weirdness going on with cr-toast background, due to the recent change that we made to paper-button style to default hairline buttons to have a white background, see  crbug.com/856918 .

 
Cc: scottchen@chromium.org dpa...@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Untriaged)
The white-background was introduced to make the paper-buttons within the Manage User web-dialog have white background.

I think this actually contradicts the purpose of the "hairline button", and hinders usages of such button on darker backgrounds in general.

I think we should revert the paper-button's default background to transparent, and just make it white for the manage user dialog, to reduce the chance of an unexpected breakage on dark background somewhere else.
Cc: nyerramilli@chromium.org aee@chromium.org rbasuvula@chromium.org
 Issue 856918  has been merged into this issue.

Comment 3 by dpa...@chromium.org, Jun 27 2018

> I think we should revert the paper-button's default background to transparent, and just make it white for the manage user dialog, to reduce the chance of an unexpected breakage on dark background somewhere else.

+1.

Comment 4 by aee@chromium.org, Jun 28 2018

Status: Started (was: Assigned)

Comment 5 by aee@chromium.org, Jun 28 2018

For now, I'm going to take the suggestion of not setting the bg-color for the default paper-button since it's a change with a larger potential impact versus changing the user-manager paper-button bg-color to white. For cr-toast, I will still set the bg-color to transparent since it is more explicit this way. Also scottchen@ noticed the bg-color needs to be fixed for the hover state as well.

Comment 6 by aee@chromium.org, Jun 29 2018

Status: Fixed (was: Started)
This is fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1115354

Comment 7 by aee@chromium.org, Jun 29 2018

 Issue 857507  has been merged into this issue.

Sign in to add a comment