[ChromeDriver] Old adb version in devil doesn't work with ChromeDriver tests |
|||
Issue descriptionDevil loads a binary of adb version 1.0.32 into src/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb. This binary is then picked up by the AdbWrapper and used to interface with the device in ChromeDriver's run_py_tests.py, but ChromeDriver needs 1.0.38 or newer per https://chromium.googlesource.com/chromium/src/+/1d522e4e12fc57741575b3da6401558b277c03cc .
,
Jun 28 2018
I tried to upgrade to 1.0.36 almost two years ago (https://chromium.googlesource.com/catapult.git/+log/e82ab88bd0dd609d283db49f5037bcdca803b049/devil/devil/devil_dependencies.json) but broke something that used telemetry -- maybe gpu tests? It's definitely high time to do this. I'm going to be upgrading platform-tools in chromium in the near-ish future; that might be a good opportunity to upgrade. into I>C>C+Android for now pending further discussion.
,
Jun 28 2018
I'm not the right owner for this. Will let jbudorick@ triage :)
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e5bb6e4e62b4863174cacd3f003a87c21782442 commit 3e5bb6e4e62b4863174cacd3f003a87c21782442 Author: Cole Winstanley <cwinstanley@google.com> Date: Fri Jun 29 22:12:37 2018 documentation for old adb bug in run_py_tests Bug: 857239 Change-Id: Ib55ad681b3cb87899cfdb9701542fff5290fe796 Reviewed-on: https://chromium-review.googlesource.com/1118913 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#571669} [modify] https://crrev.com/3e5bb6e4e62b4863174cacd3f003a87c21782442/chrome/test/chromedriver/test/run_py_tests.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by cwinstanley@google.com
, Jun 27 2018Owner: crouleau@chromium.org