New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 857224 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Chrome crashes on clicking "Cast" button; when in No Devices Found state

Project Member Reported by dbbrooks@chromium.org, Jun 27 2018

Issue description

Chrome Version: 69.0.3472.3
MR Version: 6918.621.0.0
OS: Mac, Win

What steps will reproduce the problem?
(1) Have at least one target in device list (Chromecast or meeting)
(2) Cause the device list to be emptied by disconnecting from network or removing receiver.
(3) Open dialog. Once the No device found msg appears, click on the Cast button.

What is the expected result? 1. The Cast button should be it's inactive state. Yet it is still the bright blue active color. 2. Chrome shouldn't crash :)

What happens instead? 1. The Cast button is in an active, bright blue, clickable state. 2. Chrome crashes.

Crash ID:
Uploaded Crash Report ID 045b7fc294697dd0 

 
Blocking: 754101
Labels: M-69 Target-69
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d344e1dd7e6793d36d00a41f64e1d92c21fb27f4

commit d344e1dd7e6793d36d00a41f64e1d92c21fb27f4
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Jul 03 18:43:41 2018

[Harmony Cast Dialog] Disable the Cast button when all sinks disappear

Clicking on the Cast button when there are no sinks causes a crash.
This CL disables the button when the dialog goes from having sinks to
empty.

Bug:  857224 
Change-Id: I8040aef278d28fbc6e6b03c04e9ff9103156ea44
Reviewed-on: https://chromium-review.googlesource.com/1119531
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572304}
[modify] https://crrev.com/d344e1dd7e6793d36d00a41f64e1d92c21fb27f4/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/d344e1dd7e6793d36d00a41f64e1d92c21fb27f4/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment