CloseGuard error in VariationsSeedLoader |
|||||||
Issue descriptionRepro like so: $ cts-tradefed run commandAndExit cts -m CtsHostsideWebViewTests -t com.android.cts.webkit.WebViewHostSideStartupTest#testStrictMode And see in logcat: E StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks. E StrictMode: java.lang.Throwable: Explicit termination method 'close' not called E StrictMode: at dalvik.system.CloseGuard.open(CloseGuard.java:223) E StrictMode: at android.os.ParcelFileDescriptor.<init>(ParcelFileDescriptor.java:192) E StrictMode: at android.os.ParcelFileDescriptor.<init>(ParcelFileDescriptor.java:181) E StrictMode: at android.os.ParcelFileDescriptor.open(ParcelFileDescriptor.java:214) E StrictMode: at org.chromium.android_webview.VariationsSeedLoader.requestSeedFromService(VariationsSeedLoader.java:357) E StrictMode: at org.chromium.android_webview.VariationsSeedLoader$SeedLoadAndUpdateRunnable.run(VariationsSeedLoader.java:242) E StrictMode: at java.lang.Thread.run(Thread.java:764) Found while investigating http://b/110798093#comment5, though this is a different bug than that one.
,
Jun 29 2018
Estelle, should we merge this, since it can cause CTS failures?
,
Jun 29 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 29 2018
,
Jul 3
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 6
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46e014cbf4865957143e65ceb78637c63c8caa0c commit 46e014cbf4865957143e65ceb78637c63c8caa0c Author: Paul Miller <paulmiller@google.com> Date: Mon Jul 09 17:55:43 2018 WebView: Fix CloseGuard error in VariationsSeedLoader The WebView requesting a variations seed opens a file descriptor to receive the seed. We should close it after the request. BUG= 857223 Change-Id: I594067ce0c33bed2137bc39e5c133ba22bca0c04 Reviewed-on: https://chromium-review.googlesource.com/1117707 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#571354}(cherry picked from commit 9aeb746195fa8bf7131c270af2c41c9b605bb894) Reviewed-on: https://chromium-review.googlesource.com/1129479 Reviewed-by: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#616} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/46e014cbf4865957143e65ceb78637c63c8caa0c/android_webview/java/src/org/chromium/android_webview/VariationsSeedLoader.java
,
Jul 9
,
Jul 18
Please add manual verification steps if necessary
,
Jul 18
No manual testing is needed. This is covered by the CTS test as described above. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 29 2018