New issue
Advanced search Search tips

Issue 857221 link

Starred by 3 users
Status: Fixed
Owner:
jdufault@chromium.org
Closed: Aug 13
Cc:
cindyb@chromium.org
abodenha@chromium.org
sdantul...@chromium.org
dsunk...@chromium.org
alemate@chromium.org
mkarkada@chromium.org
dchan@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Browse as guest, shutdown and uber tray missing on OOBE screens

Project Member Reported by sdantul...@chromium.org, Jun 27 2018 
ChromeOS 10820.0.0, 69.0.3473.0 dev-channel kevin

What steps will reproduce the problem?
(1) Powerwash device and go through OOBE screens
(2) On the OOBE screen , check if shelf is visible
(3) Complete OOBE and reach the sign-in screen. Check for shelf with Browse as guest, shutdown buttons and uber tray.

What happens ?
Shelf is not visible during OOBE and on sign-in screen.
Browse as guest, shutdown buttons and uber tray are missing.

Comment 1 by dsunk...@chromium.org, Jun 27 2018

Cc: cindyb@chromium.org
@Sahiti, Can you please also confirm the issue on other boards?

Comment 2 by sdantul...@chromium.org, Jun 27 2018 

Issue reproduced on other boards as well. Tested on eve and minnie.

Please note that clicking in the shelf area where buttons and uber tray should be present will launch those respectively though they are invisible.

Attached screenshots. 

Repro video: https://storage.cloud.google.com/chromiumos-test-logs/bugfiles/cr/857221/IMG_9011.MOV?_ga=2.38575713.-317153427.1526666211
oobe.JPG
1.8 MB View Download
sign-in.JPG
1.5 MB View Download

Comment 3 by dsunk...@chromium.org, Jun 27 2018

Cc: dsunk...@chromium.org

Comment 4 by mkarkada@chromium.org, Jun 27 2018

Cc: mkarkada@chromium.org

Comment 5 by cindyb@chromium.org, Jun 27 2018

Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Moving to RBB, this issue has been pushed with dev 100%. Use case seems to be and edge case. Should be triaged and owner assigned. 

+dchan for future testing.

Comment 6 by sdantul...@chromium.org, Jun 27 2018 

Same issue is reproducible when user installs image using recovery stick.

Comment 7 by sdantul...@chromium.org, Jun 27 2018

Cc: dchan@chromium.org
Issue not reproducible on previous dev build 10798.0.0, 69.0.3464.0 eve.

Comment 8 by alemate@chromium.org, Jun 27 2018

Owner: alemate@chromium.org
Status: Assigned (was: Untriaged)
This is known bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23375dd37c69da1a79e9e98fa3ba9e8c1c426134

commit 23375dd37c69da1a79e9e98fa3ba9e8c1c426134
Author: Alexander Alekseev <alemate@chromium.org>
Date: Thu Jun 28 02:27:22 2018

Chrome OS OOBE: make shelf consistent with new UI.

Bug:  852034 , 857221 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I70686fbe59fe1543314ca486ce95e3f2022fe9c6
Reviewed-on: https://chromium-review.googlesource.com/1117853
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571007}
[modify] https://crrev.com/23375dd37c69da1a79e9e98fa3ba9e8c1c426134/chrome/browser/resources/chromeos/login/md_header_bar.css
[modify] https://crrev.com/23375dd37c69da1a79e9e98fa3ba9e8c1c426134/chrome/browser/resources/chromeos/login/md_header_bar.html

Comment 10 by cindyb@chromium.org, Jul 26 

Has this been tested on the latest version? What is the current status? Thanks.

Comment 11 by sdantul...@chromium.org, Jul 26 

This is still an issue on latest M69 10895.5.0, 69.0.3497.14

Comment 12 by sdantul...@chromium.org, Jul 26

Summary: Browse as guest, shutdown and uber tray missing on OOBE screens (was: Browse as guest, shutdown and uber tray missing on sign-in screen after OOBE)

Comment 13 by cindyb@chromium.org, Jul 26 

Should there be a merge request to have this included in M69 now that it is branched?

Comment 14 by cindyb@chromium.org, Jul 31

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Per conversation with alemate@, moving to RBS as it does not block users.

Comment 15 by jdufault@chromium.org, Aug 3

Owner: jdufault@chromium.org
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8

commit 8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Aug 07 20:39:57 2018

cros: Change status area tray icon color and background in OOBE

OOBE now has a white background across the entire display. The status area tray
icons were not visible in this environment.

Bug:  857221 
Change-Id: I025b8f0d243df6be4d1b0258628dc72730467341
Reviewed-on: https://chromium-review.googlesource.com/1162780
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581335}
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/shelf/shelf_background_animator.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/shelf/shelf_background_animator_unittest.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/date/date_view.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/date/date_view.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/date/tray_system_info.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/date/tray_system_info.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/network/network_icon.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/network/network_icon.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/network/network_icon_unittest.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/network/network_tray_view.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/network/network_tray_view.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/power/tray_power.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/power/tray_power.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/tray/tray_constants.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/tray/tray_constants.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/tray/tray_utils.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/unified/ime_mode_view.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/unified/ime_mode_view.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/unified/unified_system_tray.h
[modify] https://crrev.com/8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8/ash/system/unified/unified_system_tray_test_api.cc

Comment 17 by jdufault@chromium.org, Aug 7

Labels: Merge-Request-69
Project Member

Comment 18 by sheriffbot@chromium.org, Aug 8

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11811235ad21518de356b8bc3d3e33d22de47574

commit 11811235ad21518de356b8bc3d3e33d22de47574
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Aug 10 18:33:18 2018

cros: Cleanup shelf background animator

ShelfBackgroundAnimator determined color by looking at both ShelfBackgroundType
and also the session state. ShelfBackgroundType was set from ShelfLayoutManager.

Both ShelfLayoutManager and ShelfBackgroundAnimator observed session state
changes and updated the shelf colors from that. This means that there were
multiple color updates, and beyond that the rendered background type could
diverge from what was requested by ShelfLayoutManager in the time between the
two callbacks.

Remove the ability for ShelfLayoutManager to observe session state changes, and
encode the needed information in ShelfBackgroundType. This simplifies control
flow and reduces complexity.

Bug:  857221 
Change-Id: I173e8cc47d7f6f22123814d341a94749472f7932
Reviewed-on: https://chromium-review.googlesource.com/1168028
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582259}
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/public/cpp/shelf_types.h
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/shelf/shelf_background_animator.cc
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/shelf/shelf_background_animator.h
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/shelf/shelf_background_animator_unittest.cc
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/11811235ad21518de356b8bc3d3e33d22de47574/ash/shelf/shelf_widget.h

Comment 20 by jdufault@chromium.org, Aug 10 

note: only 8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8 needs to be merged

Comment 21 by cindyb@google.com, Aug 13

Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 13

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd

commit d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Aug 13 18:05:55 2018

cros: Change status area tray icon color and background in OOBE

OOBE now has a white background across the entire display. The status area tray
icons were not visible in this environment.

TBR=jdufault@google.com

(cherry picked from commit 8df8b5d28d1b6ec892d731a2891cf6dddab6c8d8)

Bug:  857221 
Change-Id: I025b8f0d243df6be4d1b0258628dc72730467341
Reviewed-on: https://chromium-review.googlesource.com/1162780
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581335}
Reviewed-on: https://chromium-review.googlesource.com/1173056
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#570}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/shelf/shelf_background_animator.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/shelf/shelf_background_animator_unittest.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/date/date_view.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/date/date_view.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/date/tray_system_info.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/date/tray_system_info.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/network/network_icon.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/network/network_icon.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/network/network_icon_unittest.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/network/network_tray_view.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/network/network_tray_view.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/power/tray_power.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/power/tray_power.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/tray/tray_constants.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/tray/tray_constants.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/tray/tray_utils.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/unified/ime_mode_view.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/unified/ime_mode_view.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/unified/unified_system_tray.h
[modify] https://crrev.com/d9e8808969c1b7f70d98e5ae52c53a48ba3dddbd/ash/system/unified/unified_system_tray_test_api.cc

Comment 23 by jdufault@chromium.org, Aug 13

Status: Fixed (was: Assigned)
►

Sign in to add a comment