New issue
Advanced search Search tips

Issue 857218 link

Starred by 1 user
Status: Fixed
Owner:
moh...@chromium.org
Closed: Aug 8
Cc:
xing...@intel.com
sadrul@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 851488



Sign in to add a comment

Remove GpuClient dependency on GpuProcessHost

Project Member Reported by moh...@chromium.org, Jun 27 2018 
This is needed to remove GpuClient dependency on content.

Currently, GpuClient[Impl] uses GpuProcessHost to call into GpuService, trying to relaunch the GPU process if it is not already running. GpuClient should mostly be able to call directly into GpuService. In cases it is not possible, GpuClient can use a delegate interface to call into GpuProcessHost.

Comment 1 by moh...@chromium.org, Jul 4

Cc: -moh...@chromium.org
Owner: moh...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795

commit bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Wed Aug 08 02:55:00 2018

Remove GpuClientImpl dependency on GpuProcessHost

This is part of removing GpuClientImpl dependency on content so we can
move it //components/viz/host/. A delegate interface is added with an
implementation in content to provide access to GpuProcessHost for now.

BUG= 857218 

Change-Id: I673860ada761e21eb77aa5b6a3272c96d02406ef
Reviewed-on: https://chromium-review.googlesource.com/1137742
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581451}
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/BUILD.gn
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/browser_gpu_channel_host_factory.cc
[add] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/browser_gpu_client_delegate.cc
[add] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/browser_gpu_client_delegate.h
[add] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/gpu_client_delegate.h
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/bd50b1c0b4eb22d57b67dd75b376fa1d20c0b795/content/browser/service_manager/common_browser_interfaces.cc

Comment 3 by moh...@chromium.org, Aug 8

Status: Fixed (was: Started)
►

Sign in to add a comment