Ignore EC SPI flash protect state when disabling USB-PD in RO |
||
Issue descriptionCurrently, SPI flash has to be write protected for USB PD to be disabled while EC is in RO. This makes what dogfooders see greatly different from what normal users will see. We should not consider SPI flash protect state when enabling/disabling USB PD at start-up in EC-RO.
,
Jun 30 2018
We're thinking about introducing a new flag in EC-RO: 0: PD is disabled regardless of SPI WP state (proposed behavior) 1: PD is enabled if SPI WP is off (current behavior) This flag should be ideally located somewhere addressed by fmap so that it can be changed without recompilation (just like GBB flags). For those who need to disable soft-sync (for whatever reasons), we can offer a tool setting the flag to 1. Alternatively, the flag can be: 0: PD is disabled in RO 1: PD is enabled in RO This scheme is simpler but we have to make sure we won't ship devices with the flag set (while in the 1st scheme, it doesn't matter because PD is disabled as long as SPI WP is on).
,
Jun 30 2018
Factory finalize should use a host command to read the flag(s) to ensure they're in the proper state. Similar to how it checks AP's GBB flags.
,
Jul 13
One example of confusion: https://issuetracker.google.com/80052680.
,
Aug 7
|
||
►
Sign in to add a comment |
||
Comment 1 by vpalatin@chromium.org
, Jun 28 2018