Issue metadata
Sign in to add a comment
|
DCHEK in WillHandleBrowserAboutURL() when navigating to "about:Blank" |
||||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3475.0 (Developer Build) (64-bit) OS: Linux What steps will reproduce the problem? (1) Open chrome. (2) In omnibox, type "about:Blank" (or alternatively turn any other letter in "blank" to uppercase). (3) DCHECK in WillHandlBrowserAboutURL(). What is the expected result? URL gets fixed up and no DCHECK fired. What happens instead? DCHECK fires. Note that "About:blank" works fine.
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7009ded58aa656683563186738fc6e38e79d988a commit 7009ded58aa656683563186738fc6e38e79d988a Author: Ehsan Karamad <ekaramad@chromium.org> Date: Thu Jun 28 16:08:26 2018 Fix a DCHECK in WillHandleBrowserAboutURL() The code in FixupURL does not properly handle "about:blank" variants where some letter in "blank" is uppercase. This CL fixes the issue by returning "about:blank" when the lowercase of the input URL is "about:blank". Bug: 857201 Change-Id: Ia1ff719d142ae8f2a346cbca231e52a811e9b77c Reviewed-on: https://chromium-review.googlesource.com/1117627 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571147} [modify] https://crrev.com/7009ded58aa656683563186738fc6e38e79d988a/components/url_formatter/url_fixer.cc [modify] https://crrev.com/7009ded58aa656683563186738fc6e38e79d988a/components/url_formatter/url_fixer_unittest.cc
,
Jun 28 2018
,
Jun 29 2018
Marking fixed per comment #2. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by ekaramad@chromium.org
, Jun 27 2018