New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 857193 link

Starred by 1 user
Status: Fixed
Owner:
alemate@chromium.org
Closed: Jul 14
Cc:
█ elizabethchiu@chromium.org
shihuis@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Swap out the sound file for Chrome OS

Project Member Reported by shihuis@google.com, Jun 27 2018 
Feature description:
-- Swap out the device bootup sound

Eng owner: alemate
Product owner: shihuis

The sound file is here: https://drive.google.com/corp/drive/folders/1Gxue25ShTyO6BNmcEHxbhuDH4IXrnn5j
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/browser_internal/+/f3066ce0bca2b504260b5340de012f72f21cf731

commit f3066ce0bca2b504260b5340de012f72f21cf731
Author: Alexander Alekseev <alemate@google.com>
Date: Fri Jul 13 00:21:19 2018
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/d464e6a800051eae87759ca2a15b121e2abe1153

commit d464e6a800051eae87759ca2a15b121e2abe1153
Author: Alexander Alekseev <alemate@google.com>
Date: Fri Jul 13 00:26:20 2018
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/199c4086bba0c5f741c25a1629b50134eb687247

commit 199c4086bba0c5f741c25a1629b50134eb687247
Author: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 13 01:36:34 2018

Roll src-internal bc787be40f68..d464e6a80005 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc787be40f68..d464e6a80005


Created with:
  gclient setdep -r src-internal@d464e6a80005

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:857193 
TBR=mmoss@chromium.org

Change-Id: I19ceae1ab29c387475500c5269913be2f20633fe
Reviewed-on: https://chromium-review.googlesource.com/1135620
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574808}
[modify] https://crrev.com/199c4086bba0c5f741c25a1629b50134eb687247/DEPS
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410f2c4912d46a5fae2fe6c0b2e24d9eb6359761

commit 410f2c4912d46a5fae2fe6c0b2e24d9eb6359761
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Jul 13 23:44:31 2018

Chrome OS OOBE: Use new startup sound for Google Chrome build.

Bug:  857193 , b/79987581
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iebac32d290096c148a615bf0b3d1278a9038649b
Reviewed-on: https://chromium-review.googlesource.com/1136010
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575117}
[modify] https://crrev.com/410f2c4912d46a5fae2fe6c0b2e24d9eb6359761/chrome/browser/browser_resources.grd
[delete] https://crrev.com/29f92361cbf018cc8af847ac3cc4d52224d5a2d5/chrome/browser/resources/chromeos/sounds/startup2.wav

Comment 5 by alemate@chromium.org, Jul 14

Status: Fixed (was: Assigned)

Comment 6 by shihuis@google.com, Jul 16 

Thank you!
►

Sign in to add a comment