Prevent assigning labels like pool:pool:cq to DUTs using the atest tool. |
|||
Issue descriptionImplement a regular expression validator in atest for labels assigned to DUTs in the lab. See postmortem: https://docs.google.com/document/d/15MyrGbdYSSSY5kqKMzVElNhZHw14e3EOv4lpIW5TNs8/edit?ts=5b2af228#
,
Jul 10
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1101897 I'll go looking to assign :-) a volunteer later this week.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/81ef224f0d8642f6cf098b6c1e5045dd745cb080 commit 81ef224f0d8642f6cf098b6c1e5045dd745cb080 Author: Richard Barnette <jrbarnette@chromium.org> Date: Thu Jul 12 01:48:35 2018 [autotest] Add pool name sanity checks for balance_pool Recently, a user accidentally uttered a command along these lines: balance_pool -t $N pool:cq $MODEL The command happily went and assigned $N suites DUTs the label "pool:pool:cq". That was... unhelpful. This adds a sanity check against pool name arguments to prevent a recurrence. BUG= chromium:857170 TEST=run the command with bad arguments, see an error message Change-Id: I9421f51b953d50f67cda51e4c4a42f955c9b0ae4 Reviewed-on: https://chromium-review.googlesource.com/1101897 Commit-Ready: Richard Barnette <jrbarnette@chromium.org> Tested-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/81ef224f0d8642f6cf098b6c1e5045dd745cb080/site_utils/balance_pools.py
,
Jul 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by akes...@chromium.org
, Jul 9Owner: jrbarnette@chromium.org
Status: Assigned (was: Untriaged)